Skip to content

Fail at startup on unknown element types in <content> #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderoster merged 1 commit into from
Oct 27, 2026
Merged

Fail at startup on unknown element types in <content> #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Implementation/UI/amc_ui_module_content.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,15 @@ CUIModule_Content::CUIModule_Content(pugi::xml_node& xmlNode, const std::string&

auto children = xmlNode.children();
for (auto childNode : children) {
std::string sChildName = childNode.name();
if (sChildName.empty())
// Only element children define submodules; comments, text and processing instructions are skipped.
if (childNode.type() != pugi::node_element)
continue;

if (!CUIModule_ContentLeaf::isSupportedModuleType(sChildName) &&
!CUIModuleFactory::moduleTypeIsRegistered(sChildName))
continue;
// An unknown element is a configuration error. Skipping it silently leaves the client with a
// module it cannot render, which surfaces only as an obscure client-side crash after login.
std::string sChildName = childNode.name();
if (!CUIModuleFactory::moduleTypeIsRegistered(sChildName))
throw ELibMCCustomException(LIBMC_ERROR_INVALIDMODULETYPE, sChildName);

auto sSubModuleName = readSubModuleNameFromXML(childNode, sChildName);
auto nameAttrib = childNode.attribute("name");
Expand Down
Loading