Repository navigation
fix(bedrock): guard _chunk_bytes_to_sse against None in stream decoder - #1976
Open
chauvuusvn wants to merge 2 commits into
Open
chauvuusvn wants to merge 2 commits into
chauvuusvn wants to merge 2 commits into
Conversation
…m decoder - Add falsy guard at chunk bytes extraction site to drop None and empty bytes - Restore clean bytes signature for _chunk_bytes_to_sse without pyright ignores - Add regression test for empty and null bytes frames in bedrock eventstream
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1975
Summary
In
anthropic.lib.bedrock._stream_decoder._chunk_bytes_to_sse,raw.decode()was called without checking ifrawisNoneor non-bytes. When AWS Bedrock stream parser receives an event with empty or missing"bytes",chunk.get("bytes")returnsNone, raisingAttributeError: 'NoneType' object has no attribute 'decode'and crashing the stream.Fix
_chunk_bytes_to_sseagainstNoneand non-bytes instances.test_chunk_bytes_to_sse_drops_none_and_non_bytestotests/lib/test_bedrock.py.