Repository navigation
Fix General scientific notation carry (10E+14 -> 1E+15) - #106
Open
arancool3000 wants to merge 1 commit into
Open
arancool3000 wants to merge 1 commit into
arancool3000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
In
General,getExp()rounds the mantissa to 5 decimals but never checks for a carry, so values like999999999999997came out as10E+14instead of Excel's1E+15(also-999999999999997,99999999999999.7,9.9999999999997E-11).Fix
In
src/general.tsgetExp(), if the rounded mantissa reaches 10, reset it to 1 and bump the exponent before building the output.How tested
test/ssf-general.spec.tswith the five values from the issue (fails before the fix with10E+14, passes after).npm testand the full table suite (vitest run) pass: 53080 passed; eslint andtsc --noEmitclean.This addresses point 1 of #105 only. Points 2 (five significant digits from exponent ±99) and 3 (subnormals shown as
0) are left for a separate change.Part of #105
AI-assisted (Claude); reviewed before submission.