Repository navigation
Conversation
This was referenced Nov 12, 2026
1. Добавлен standalone-компонент ExtraCaptionComponent (extra-caption): подпись под полем формы — иконка и текст, 14px, letter-spacing −0.32, отступ 2. 2. Вход severity (base, success, warning, danger, info) с соответствующей иконкой: ti-alert-circle, ti-circle-check, ti-alert-triangle, ti-circle-x, ti-info-circle. 3. Компонент опубликован отдельной точкой входа @cdek-it/angular-ui-kit/components/caption. Заметки для ревьюеров: - Новый публичный API: ExtraCaptionComponent и тип ExtraCaptionSeverity; severity по умолчанию base. - Стили лежат в caption.component.css и используют только глобальные CSS-переменные темы --p-*, поэтому подпись работает и в полях, чей css PrimeNG не подключён. - Цвета: fg.muted для base и fg.status.*.default для остальных severity; измерено по Figma в light и dark. - В этой ветке компонент нигде не используется; inputtext и textarea подключают его в своих ветках.
khaliulin
force-pushed
the
feature/tokens-base-figma-sync
branch
from
November 12, 2026 17:42
b7f386f to
136fbf9
Compare
khaliulin
force-pushed
the
feature/form-caption-figma-sync
branch
from
November 12, 2026 17:42
b7fbbd2 to
bb4a31d
Compare
This was referenced Nov 13, 2026
1. Обёртка extra-image над p-image: 7 входов и слоты extraImageTemplate для иконок панели. 2. Панель: 36px кнопки, 16px иконки, белый фон с тенью, hover/focus из токенов, маска через backdrop. 3. Stories по одному состоянию: Default, Preview, Width, Crop, Frame; Docs и токены обновлены. Заметки для ревьюеров: - 19 токенов в components.image; focusRing — fg.brand.active (green 700) ради контраста. - API: 7 входов и 5 слотов, ломающих изменений нет; эталона Figma нет. - descriptions-gate — SKIPPED: компонента нет в origin/main.
1. Снимать блокировку прокрутки body при уничтожении обёртки с открытым предпросмотром. 2. Переопределить нативные токены image.preview.mask: фон маски и контрастный цвет иконки. 3. Перевести живой шаблон story на биндинги и экранировать значения Controls в snippet. 4. Добавить регрессионный тест на снятие блокировки прокрутки при уничтожении. Заметки для ревьюеров: - Токены изменены только в components.image; check-component и check-stories-source проходят. - Karma-тест ExtraImageComponent и сборка библиотеки проходят; e2e image — 12 passed, 2 known.
feat(image): add ExtraImage component and preview toolbar
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the shared
ExtraCaptionComponentfor the hint under a form field, built from Figma_<Caption>. Form fields (inputtext, textarea and later others) reuse it instead of their own caption markup.Changes
extra-captioncomponent: icon plus text, 14px, letter spacing -0.32, gap 2.severityinput (base, success, warning, danger, info) with a matching icon.@cdek-it/angular-ui-kit/components/caption.API changes
ExtraCaptionComponent(<extra-caption>) and theExtraCaptionSeveritytype are new.severity:'base' | 'success' | 'warning' | 'danger' | 'info', defaultbase.Technical notes for reviewers
caption.component.cssand use the global--p-*theme variables only, so the caption also works in fields whose PrimeNG css is not loaded.fg.mutedfor base,fg.status.*.defaultfor the other severities.ti-alert-circle, infoti-info-circle, successti-circle-check, warningti-alert-triangle, dangerti-circle-x.Visual changes
None on its own. Measured against Figma in light and dark themes for all five severities when used in inputtext.
Verification
tscfor the app and Storybook projects: pass.check-pushagainst the tokens branch: no failures.Known issues and open questions
None.
Stack
Base:
feature/tokens-base-figma-sync(#192). Followed by the inputtext PR.