Skip to content

Flatpak: keep the toolchain unstripped - #36

Merged
charlesabarnes merged 1 commit into
mainfrom
fix/flatpak-build
Nov 10, 2026
Merged

charlesabarnes merged 1 commit into
mainfrom
fix/flatpak-build

Conversation

@charlesabarnes

@charlesabarnes charlesabarnes commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

flatpak-builder's strip pass broke rustc's libLLVM. Also lets the release workflow run by hand without a tag.

Summary by CodeRabbit

  • Release Improvements
    • Releases can now be started manually in addition to being triggered by version tags. Release jobs continue to run only for tag-based releases.
    • Flatpak artifact filenames now replace slashes in version tags with hyphens, ensuring the version is reflected in a valid filename.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release workflow can now start manually or on version-tag pushes. The Flatpak artifact filename replaces slashes in the tag-derived version with hyphens, and the release job runs only for tag refs. The Rust and Zig Flatpak modules set build options to disable stripping and debuginfo generation.

Changes: Release packaging

Layer / File(s) Summary
Flatpak build options
packaging/flatpak/io.github.charlesabarnes.CodeDucky.yml
The Rust and Zig modules set options that disable stripping and debuginfo generation.
Release workflow
.github/workflows/release.yml
The workflow adds manual dispatch alongside version-tag pushes. The Flatpak artifact filename replaces / with -, and the release job is restricted to tag refs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 69d40

Manual branch builds can produce artifacts without publishing a release. No merge-blocking risk was identified.

Security architecture risk: Low · up to 69d40

Manual builds are added while release creation remains tag-only and draft-only. No authorization bypass was demonstrated, but unavailable access and tag-protection settings leave limited security uncertainty.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The configured privileged scope is this repository’s contents and release assets. Selected code executes in the build jobs with workflow-wide write permission requested; effective token restrictions and protections that might distinguish dispatchers from version-tag publishers are not established by the supplied evidence.

Security Findings and Attack Paths

  • inferred — The source establishes a new privileged invocation path, but not an authorization bypass. Write permission and execution of repository build code already existed for version-tag runs. Whether manual dispatch crosses a stronger protected-tag boundary depends on unavailable repository policy.

Trust Boundaries and Controls

  • observed — Branch dispatches are excluded from the release job. Tag dispatches can satisfy its condition regardless of the v* push filter, but release creation remains configured as draft-only. These are distinct controls over invocation, ref eligibility and release visibility.

Resilience and Maintainability Implications

  • observed — Neither version explicitly configures concurrency control or cleanup and recovery after release-action interruption. This is a pre-existing limitation, not a demonstrated PR-introduced failure; same-tag repetition and cancellation behavior remain unverified.

Hardening Proposals

  • proposed — As defense in depth, narrow build jobs to the permissions they require and reserve contents write authority for the tag-gated release job. This would reduce credential exposure during builds without asserting an existing authorization bypass.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: keeping the Flatpak toolchain unstripped.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6504a02a-d020-430c-b0e2-220c44765725
Commits

Reviewing files that changed from the base of the PR and between 21b2f37 and 69d4068.

Files selected for processing: 2

  • .github/workflows/release.yml
  • packaging/flatpak/io.github.charlesabarnes.CodeDucky.yml

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

@charlesabarnes
charlesabarnes merged commit e092c6a into main Nov 10, 2026
3 checks passed
@charlesabarnes
charlesabarnes deleted the fix/flatpak-build branch November 10, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant