Repository navigation
Conversation
|
First run of the browser suite on this branch (it had never run): 88 passed, 2 failed.
|
Audit of this draft against ADR-0008 (two independent readings, 2026-11-18)Nothing was run for this audit: every point is from reading the code of Must be corrected, each with a test that fails without the correction
Decide, then correct or record in the status document
Tests that are missing
Documents
Housekeeping
Found sound and not repeated here: the reply's target is the envelope sender and one whole address; nothing of the incoming message is reflected; it leaves only through the one sending path and is counted; no pattern or SQL is built from a person's text; a broken rule cannot fail a delivery; the six routes carry the rights the record names; the assistant and MCP cannot read or change rules; rule text reaches the page as text only; logs and audit rows carry no mail content. |
…ailbox ADR-0008, in the mailbox and its routes. A mailbox's filters and blocked senders run once, where an arrival is filed, by one pure function over a closed vocabulary; the automatic reply answers a person once in seven days by RFC 3834 and leaves by the one function that lets mail leave. With the corrections of the audit of the draft: the envelope sender is asked of the block list; only mail filed in the Inbox wakes the assistant; a waiting reply is asked again whether it is on, and needs its saver to still hold mailbox.manage; a reply that does not leave for a reason of the mailbox answered nobody; a waiting reply is nobody's to take back or give a time; text and HTML are taken together only when they agree; a block can say it means one whole address; the rules routes stop reading at 256 KiB; turning the reply off keeps no stranger's address. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
Two settings tabs, "Filters and blocked senders" and "Automatic reply", and on a message "Block the sender" and "Filter messages like this" for an owner of the mailbox. A block is offered only for a whole address and says so in its request; the automatic reply shows the text of what is sent. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
The roadmap, the feature scope, the architecture, the status with what ADR-0008 leaves open and what was decided while building, the ledger entry for the mailbox's name, rule D6 and the security skill. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
d2d93e3 to
065f6b7
Compare
|
Answer to the audit of the draft. Rebased on The seven corrections
The five points to decide
The missing tests
DocumentsThe status document records 8, 11 and 12, the guards taken out, and what was not tried in a browser: the block not offered for a sender without an Two things that are new here
The PR stays a draft until CI is green. |
| const { cookie } = JSON.parse(readFileSync(session, "utf8")) as { cookie: string }; | ||
| const made = await fetch(`${BASE}/api/v1/mailboxes`, { | ||
| method: "POST", | ||
| headers: { cookie, origin: BASE, "content-type": "application/json" }, |
Second audit, at 065f6b7: five corrections, then passTwo readings again: mine of the seven corrections, and an independent one of the whole change that was not told what the first audit found. Nothing was run for either; CI on this head is green (both What holdsAll seven corrections are in the code as the answer describes them, and each has the test it names:
Points 8 to 12 are decided and recorded as the answer says, To correct, each with a test that fails without itA. A person can save HTML they were never shown. B. The mailbox can answer itself through a C. A stopped reply does work for every message, without a bound. With correction 5, a reply that fails with D. A waiting reply leaves with the words of an earlier save. A reply can wait for hours behind a "not now" or a full cap. Only on/off and the dates are asked again when it leaves; if the reply was edited, or saved by someone else, the old text leaves on the old saver's standing. E. Tests that are missing
To write down in the status document (not defects)
Not provable by readingWhether the sending service carries The documents say "built 2026-11-18"; that date holds only if this merges on that day. |
What and why
A first build of ADR-0008: a mailbox's rules for its incoming mail. Blocked senders, filters, and an automatic reply that leaves through the one sending path of ADR-0016. Refs #29.
Corrected after the audit of the draft (see the comment that answers it). Three commits: mailbox and routes, app, documents. On the builder's machine
pnpm check,pnpm test:workerdandpnpm e2epass at the head; it leaves draft when CI agrees.Before this leaves draft
Checklist
pnpm checkandpnpm test:workerdare green.test/workerd/auto-reply.test.tsandtest/workerd/rules.test.ts; not yet reviewed.)git commit -s).🤖 Generated with Claude Code