Skip to content

fix(app): a mailbox's settings are saved when the app holds them - #51

Merged
Madraka merged 1 commit into
mainfrom
fix/saved-means-loaded
Nov 18, 2026
Merged

Madraka merged 1 commit into
mainfrom
fix/saved-means-loaded

Conversation

@Madraka

@Madraka Madraka commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

What and why

Saving a mailbox's settings said "saved" before the app had read the mailbox again. A person who saved a signature and pressed Compose at once got a window without it. The save now ends when the app holds what was saved.

Found through the browser suite's failure on #46 (mailbox.spec.ts › "settings are in tabs…"), which is this race and not that branch. The test now holds the app's re-read back for a second, so the order is forced: it fails every time without the change and passes with it (both tried locally).

Refs #47.

Checklist

  • pnpm check and pnpm test:workerd are green. (CI runs them here; locally the one browser test, with and without the change.)
  • Original work. Nothing here comes from another mail product: no code, schema, test, text, translation or asset. No dependency under AGPL or GPL.
  • If this touches a trust boundary, it ships a regression test, and I say which one below. (It does not.)
  • If this relies on a Cloudflare fact, the current source and the date I read it are in the change. (It does not.)
  • Commits are conventional and signed off (git commit -s).

🤖 Generated with Claude Code

Saving a mailbox's settings told its caller it was done and only then
read the mailbox again. A person who saved a signature and wrote at once
got a window without it, because the window read the copy from before.
The save now ends when both lists have been read again.

Seen in CI on 2026-11-18. The browser test now holds the answer back for
a second: it fails every time without this change and passes with it.

Refs #47

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
@Madraka Madraka added this to the Milestone 3: version 0.1 milestone Nov 18, 2026
@Madraka Madraka added bug Something isn't working area: app The single-page app under app/ labels Nov 18, 2026
@Madraka
Madraka merged commit b62d6a1 into main Nov 18, 2026
3 checks passed
@Madraka
Madraka deleted the fix/saved-means-loaded branch November 18, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: app The single-page app under app/ bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant