Repository navigation
fix(app): a mailbox's settings are saved when the app holds them - #51
Merged
Merged
Conversation
Saving a mailbox's settings told its caller it was done and only then read the mailbox again. A person who saved a signature and wrote at once got a window without it, because the window read the copy from before. The save now ends when both lists have been read again. Seen in CI on 2026-11-18. The browser test now holds the answer back for a second: it fails every time without this change and passes with it. Refs #47 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
2 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Saving a mailbox's settings said "saved" before the app had read the mailbox again. A person who saved a signature and pressed Compose at once got a window without it. The save now ends when the app holds what was saved.
Found through the browser suite's failure on #46 (
mailbox.spec.ts› "settings are in tabs…"), which is this race and not that branch. The test now holds the app's re-read back for a second, so the order is forced: it fails every time without the change and passes with it (both tried locally).Refs #47.
Checklist
pnpm checkandpnpm test:workerdare green. (CI runs them here; locally the one browser test, with and without the change.)git commit -s).🤖 Generated with Claude Code