Skip to content

fix: resolve Snyk findings (hardcoded secrets in tests, urllib3 floor) - v1.11.3 - #192

Open
reeshika-h wants to merge 3 commits into
developmentfrom
fix/snyk-secrets-and-urllib3
Open

reeshika-h wants to merge 3 commits into
developmentfrom
fix/snyk-secrets-and-urllib3

Conversation

@reeshika-h

Copy link
Copy Markdown
Contributor

Summary

Resolves the open Snyk tickets for this repo (v1.11.3).

Snyk Code — hardcoded passwords / non-cryptographic secrets (tests only) — DX-22180 to DX-22195

  • Replaced hardcoded values in tests/api, tests/mock, tests/integration, tests/unit with env-backed (tests/cred.py) or per-run generated values, per the dummy-secret standard (SDK sink properties are env/computed with no literal).
  • Removed the # deepcode ignore suppression comments.
  • No change to the published package.

Snyk SCA — urllib3 2.7.0 — DX-27815, DX-27816, DX-27817

  • Raised the minimum to urllib3>=2.8.0,<3.0.0 in requirements.txt and setup.py (improper certificate validation, resource allocation without limits, infinite loop).

Version bumped to 1.11.3 with a CHANGELOG entry.

Verification

  • snyk code test --org=contentstack-developer-ecosystem: 0 issues (was 17).
  • snyk test --file=requirements.txt: no vulnerabilities; only the transitive certifi MPL-2.0 licence note remains (no code fix).
  • tests/unit/contentstack + tests/unit/test_oauth_handler.py: 156 passed.
  • tests/mock/users::test_mock_get_user and test_mock_user_update fail identically on main (live login in setUp); unrelated to this change.

🤖 Generated with Claude Code

reeshika-h and others added 3 commits October 26, 2026 12:28
Replace hardcoded passwords and secrets in tests with env/cred-helper
values or per-run generated values, and drop the deepcode ignore
suppression comments. Clears the Snyk Code NoHardcodedPasswords and
HardcodedNonCryptoSecret findings.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
urllib3 2.7.0 is affected by improper certificate validation, resource
allocation without limits and an infinite loop; 2.8.0 fixes all three.
Raise the minimum so the vulnerable version is no longer installable.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@reeshika-h
reeshika-h requested a review from a team as a code owner October 26, 2026 07:00
@snyk-io

snyk-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 2
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant