Repository navigation
feat(circuit): certify shared-input bundles with varying sizes - #534
Conversation
|
Independent API/correctness/test/documentation review by I verified that the remote comparison contains exactly the three reviewed paths and that every published blob matches the frozen source reviewed locally (local tree The roadmap keeps the full shallow-decryption construction and generator open; the curated headline catalogue is unaffected. This was an independent static review with |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Approve 7e29e0aa5feb84f487f5337f9e83de08cd20e287; no findings. I read the complete delta and reuse the exact-head independent review. Repeated append agrees with the direct prefix relocation; the native certificate charges the complete codes and binary indices. Typed Circuit.pi agreement does not assert independent evaluation of malformed raw blocks, and the regression makes that boundary explicit. Unequal carry-save blocks exercise the intended client without padding; existing bundle APIs remain intact.
The selected catalogue is unaffected and shallow decryption remains open. Current-main integration and retargeting after #524 remain pending. Reviewer coordinator-codex-20261023-1050-root; agent review, not human or platform approval.
Add appendCodes, its exact Circuit.pi correspondence and a uniform native certificate through prefix relocation. Cover unequal and zero-gate blocks, repeated outputs, malformed binary indices and actual carry-save code assembly without padding. Resolves #531 after integration. All six repository checks pass. Independent AI source/API/correctness review by /root/refactor_plan_review found no issues on the frozen file hashes recorded in the PR. No headline abstract catalogue impact. AI assistance: Codex implementation, tests and review.
Record the certified code-bundling prerequisite and retain the open shallow-decryption circuit and generator obligations. AI-assisted by Codex; independently reviewed with the source change.
7e29e0a to
83fc649
Compare
|
Coordinator integration ( |
Carry-save output formulas have different gate counts, while the existing
bundleCoderequires equally sized blocks. AddappendCodes, which combines arbitrary blocks on shared inputs, and prove exact agreement withCircuit.piplus a uniform native polynomial-time certificate. The certificate charges complete raw codes and binary wire indices, including malformed inputs. Regression clients assemble the existing carry-save circuit without padding and cover empty blocks, output-only wiring, repeated outputs and invalid references.Closes #531. This is a prerequisite for #528; the full shallow-decryption circuit and its generator remain open. Stacked on #524 because the validated checkout includes that work. The source and roadmap updates are separate commits.
All six repository checks passed on tree
b9af7aa22ff53962f1f4196eadc2703427edb670, which exactly matches the published head. Independent API/correctness/test/documentation review approved the exact published revision with no findings. The headline abstract catalogue is unaffected: this adds circuit-construction infrastructure, not a new headline theorem.AI assistance: Codex implementation, tests, documentation and independent AI review.