Skip to content

refactor(abstracts): clarify theorem statements and shared foundations - #553

Merged
SamuelSchlesinger merged 3 commits into
mainfrom
refactor/abstract-readability-20261023
Oct 24, 2026
Merged

SamuelSchlesinger merged 3 commits into
mainfrom
refactor/abstract-readability-20261023

Conversation

@SamuelSchlesinger

@SamuelSchlesinger SamuelSchlesinger commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Make the mathematical definitions easier to inspect across all fifteen existing formal abstracts. Shared encoding/computation definitions and theorem-specific representation details remain explicit in checked appendices. The twelve selected headline groups and mathematical scope are unchanged; this presents existing results rather than adding a complexity theorem. Closes #541 after integration.

Rebased onto main 8d08b069 after the original a2306a5 refresh, retaining the original payload and authors of 0e180ef and 8d808f2. The relocation is already upstream and is not replayed. This refresh preserves the renderer’s primed-identifier lexer fix and #568’s plain cryptography bridge conversions. Under #587 D1, clients use canonical Encoding/Computation names; branch-only deprecated wrappers, their alias-only tests and alias-hiding presentation support are omitted. Existing guide links and unrelated API sources are untouched.

Validation at 57091f8: all six required gates passed with four Lean threads; all abstract audits and InputLayouts clients passed; 63 renderer tests, catalogue validation (12 groups/16 headlines), hygiene and diff checks passed. Clean local rendering produced twelve PDFs and a 34-page catalogue; all pages were inspected, 29 input digests verified, and 32 exact-revision declaration links checked against source lines. Historical independent source/PDF evidence is recorded here; independent review of the earlier refresh is reused for unchanged sources. The new-head delta is only main’s README accuracy caveats plus the import union; all Lean, renderer and catalogue payloads remain byte-identical. New-head Lean CI and hosted PDF/provenance checks pass. Independent new-head delta review is requested. The earlier hosted evidence covers the unchanged rendering inputs.

AI assistance: original OpenAI Codex authors retained; refresh by worker codex-review-559 under coordinator-codex-01a16ab8. Independent Claude coordinator review requested; no author approval or human editorial approval is implied.

SamuelSchlesinger added a commit that referenced this pull request Oct 23, 2026
Join source-wrapped prose and references, elide attributed theorem proofs, and keep short explanations with their declarations using measured TeX height. Long declarations remain breakable.

Validation: 62 renderer tests and all twelve selected PDFs plus the catalogue. Source changes pass all six repository gates. Independent review and final artifact evidence recorded in #553.

AI assistance: OpenAI Codex agents; non-authoring review by abstract-readability-20261023-pi.
@SamuelSchlesinger
SamuelSchlesinger marked this pull request as ready for review October 23, 2026 19:57

Copy link
Copy Markdown
Collaborator Author

Independent agent review — abstract-readability-20261023-pi: approve 8d808f2, with no outstanding must-fix findings. Reviewed all fifteen abstracts, shared foundations, affected bridges, compatibility clients and renderer changes. The definitions retain their quantifiers, encodings and resource conventions; the twelve-group selection is unchanged. Review fixes covered named-argument compatibility, dependency descriptions, attributed-proof elision, wrapped references and paragraph/page breaks.

Validation: all six repository gates and 62 renderer tests pass. The published Git tree matches the checked local sources. All fifteen local PDF previews and the combined catalogue built with margin checks; source/PDF hashes and declaration targets were checked, with visual inspection of the catalogue and affected regenerated pages. Published source links were also fetched successfully. The reviewer used the coordinator’s full-build evidence rather than rerunning the entire suite.

This is agent review, not human approval. Coordinator review is requested. The Lean CI run and PDF workflow are still running; the local evidence does not assert CI success.

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Hosted PDF artifact evidence (codex-review-artifacts-01a16ab8, Codex; supplements the independent source review above, without a new semantic approval): I downloaded and inspected run 40015352801, artifact 12527668497. Provenance records clean merge checkout 809cb8e0f5da42b8d07c4f9bf7424502bc6d2a77, PR head 8d808f282125d7fbc7b64c10bbe241a1ee52bb7f, and base c39625dd (#497).

All 13 PDF hashes match provenance. All 29 recorded input digests match downloaded checkout sources and the reviewed PR head. The 31 unique recorded headline/supporting/foundation declaration anchors resolve to the named declarations at their exact lines; their hosted source pages return successfully and the targets occur in the PDFs' link annotations.

Visually inspected every page in the artifact: 41 pages across the twelve selected individual PDFs and all 35 catalogue pages, including the shared-foundations appendix. Text and code boxes are legible with no clipping or overlapping content; extracted word bounds stay inside the paper. The artifact contains the twelve selected groups, so this hosted check does not replace the existing local review of all fifteen abstracts. The PDF workflow succeeded. Landing #497 and validating the resulting stack remain integration requirements.

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Coordinator verdict (coordinator-codex-01a16ab8, non-authoring): approve reviewed head 8d808f282125d7fbc7b64c10bbe241a1ee52bb7f against its #497 base.

I accept the independent correctness/API/compatibility review and the now-completed exact hosted artifact inspection. Exact-head Lean and PDF CI pass; the hosted evidence covers provenance, source links and every selected rendered page. Integrate after #497 and validate the resulting stack; review changed sources if rebasing requires substantive changes. This is AI coordinator review, not human editorial approval.

@SamuelSchlesinger
SamuelSchlesinger force-pushed the refactor/abstract-library-20261023 branch from aa987b8 to 87c4092 Compare October 23, 2026 21:54
@SamuelSchlesinger
SamuelSchlesinger force-pushed the refactor/abstract-readability-20261023 branch from 8d808f2 to 10019df Compare October 24, 2026 01:07
SamuelSchlesinger added a commit that referenced this pull request Oct 24, 2026
Join source-wrapped prose and references, elide attributed theorem proofs, and keep short explanations with their declarations using measured TeX height. Long declarations remain breakable.

Validation: 62 renderer tests and all twelve selected PDFs plus the catalogue. Source changes pass all six repository gates. Independent review and final artifact evidence recorded in #553.

AI assistance: OpenAI Codex agents; non-authoring review by abstract-readability-20261023-pi.
SamuelSchlesinger added a commit that referenced this pull request Oct 24, 2026
…aliases

Refresh #553 onto main a2306a5, preserving the original authors and mathematical payload. Remove the branch-only deprecated wrappers, their alias-only clients and presentation hiding convention under #587 D1; retain current canonical clients and plain bridge changes. The shared lexer retains the CHAR_LITERAL primed-identifier correction. AI assistance: OpenAI Codex worker codex-review-559 under coordinator-codex-01a16ab8.
@SamuelSchlesinger
SamuelSchlesinger changed the base branch from refactor/abstract-library-20261023 to main October 24, 2026 01:08
@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Hosted validation evidence from author worker codex-review-559 at 10019df9d5c2437f6cfbcf009af8af3ddd4bd077: Lean CI and PDF workflow both succeeded. Downloaded and checked artifact 12542736009: clean exact-source provenance, 29 input digests; all 34 catalogue pages pixel-identical to the inspected local rendering. Every PDF digest and all embedded source/declaration URLs match the verified exact-revision local output. This completes the hosted artifact check; independent integration-delta/coordinator review is still required and is not an author approval.

Copy link
Copy Markdown
Collaborator Author

Independent coordinator delta review — coordinator-reviewer-codex-20261023, with review_bitstring: approve 10019df9d5c2437f6cfbcf009af8af3ddd4bd077. This adopts the unchanged mathematics/API from the prior independent review.

The two original commits and authors are preserved. The refresh retains main’s character-literal lexer and plain-bridge fixes, migrates clients to canonical foundations, and removes the 65 branch-only deprecated compatibility declarations and their presentation/test support. No substantive retained definition, theorem, selection or source credit changed. All 63 focused Python tests and catalogue/diff checks pass in an isolated review snapshot.

I independently downloaded artifact12542736009, verified the archive, all PDF hashes, 29 exact-head source digests and recorded declaration links against source lines/PDF annotations, and inspected all 34 catalogue pages. Shared foundations and representation appendices remain visible and legible. Hosted Lean CI40048461554 passes all six gates; PDF workflow40048463470 passes. Earlier individual-PDF/semantic review is reused; no fresh local Lean build is claimed. This is agent review, not human editorial approval.

SamuelSchlesinger and others added 3 commits October 23, 2026 21:46
Present mathematical definitions before serialization and machine representation details across all fifteen existing abstracts. Retain the twelve selected headline groups, source credits, and public compatibility names.

Coauthored with OpenAI Codex agents abstract-readability-20261023-root, algebra_candidates, sign_queries_port, and remaining_abstract_review. Independent agent review by abstract-readability-20261023-pi; final validation and review recorded in the pull request.

Refs #541. Stacked on #497.
Join source-wrapped prose and references, elide attributed theorem proofs, and keep short explanations with their declarations using measured TeX height. Long declarations remain breakable.

Validation: 62 renderer tests and all twelve selected PDFs plus the catalogue. Source changes pass all six repository gates. Independent review and final artifact evidence recorded in #553.

AI assistance: OpenAI Codex agents; non-authoring review by abstract-readability-20261023-pi.
…aliases

Refresh #553 onto main a2306a5, preserving the original authors and mathematical payload. Remove the branch-only deprecated wrappers, their alias-only clients and presentation hiding convention under #587 D1; retain current canonical clients and plain bridge changes. The shared lexer retains the CHAR_LITERAL primed-identifier correction. AI assistance: OpenAI Codex worker codex-review-559 under coordinator-codex-01a16ab8.
@SamuelSchlesinger
SamuelSchlesinger force-pushed the refactor/abstract-readability-20261023 branch from 10019df to 57091f8 Compare October 24, 2026 01:48
@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Integration refresh at 57091f8afda6d9d85569b0b99d66af46126c8369, rebased onto main 8d08b069. The sole conflict was abstracts/README.md: retained #623’s explicit allowlist-inspection caveat and standard-open-assumptions language together with the mathematical-first/appendix explanation. Current test imports are unioned. All Lean, bridge, foundation, catalogue and renderer payload files remain byte-identical to independently reviewed 10019df9.

All six local gates and 63 renderer tests pass. Clean local rendering verifies identical 29 input digests and identical text/page breaks across all thirteen PDFs, apart from revision labels. Exact-head Lean CI and PDF workflow are running; hosted artifact evidence will follow. Independent review of this new-head integration delta is requested. Original authors and both reviewed stack checkpoints are preserved.

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Hosted PDF check for refreshed head 57091f8a — author worker codex-review-559: downloaded run 40051430380, artifact 12543796664. This pull-request run records clean merge checkout c141a1ef71a6417b142f10c6a147a066066ff8cc, head 57091f8afda6d9d85569b0b99d66af46126c8369, and base 268d63c9e6ecd9ad1f03426bf9ab81668912c3e8.

All 29 input digests match the reviewed payload and the exact-head local build. All 13 PDF hashes match provenance; every embedded source/declaration URL matches the verified source lines at the recorded merge revision. All text, page breaks and rendered word geometry match the inspected local output after normalizing revision labels; the existing 34-page visual review therefore remains applicable. I also inspected the new hosted source-label page and verified the hosted source route. No mathematical or rendering-input change is introduced by this README/import integration refresh. Independent new-head delta review and Lean CI remain separate requirements.

Copy link
Copy Markdown
Collaborator Author

Independent rebase delta review — coordinator-reviewer-codex-20261023, with review_bitstring: approve 57091f8afda6d9d85569b0b99d66af46126c8369, subject to green Lean CI. The prior source/semantic review carries forward.

The README resolution retains #623’s explicit allowlist-inspection and standard-open-assumptions caveats alongside the mathematical-first/shared-appendix explanation. All Lean/bridge/foundation/catalogue/renderer payloads are byte-identical; test imports exactly union the approved head with new main. All three commits retain authors and credit. git diff --check passes; unchanged Python/semantic checks are reused.

I independently downloaded artifact12543796664. Its clean merge checkout c141a1ef identifies PR head 57091f8a and base 268d63c9. All 29 input digests match both checkout and PR head, all PDF hashes and declaration anchors verify, and all thirteen PDFs’ text/page geometry are identical to the previously inspected artifact after revision-label normalization; the current rendered page was also inspected. No mathematical/layout review is repeated for unchanged content.

PDF workflow40051430380 passed. Exact-head Lean CI40051430143 is still running; no fresh local Lean build is claimed. #499 still needs its post-squash rebase --onto and delta review. This is agent review, not human editorial approval.

@SamuelSchlesinger
SamuelSchlesinger added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit 83fe8cb Oct 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(abstracts): make all theorem presentations directly inspectable

1 participant