Skip to content

fix(hygiene): enforce source hygiene in CI #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamuelSchlesinger merged 2 commits into from
Oct 23, 2026
Merged

fix(hygiene): enforce source hygiene in CI #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065906a
style(circuit): state the carry-lookahead step size proof with simp only
SamuelSchlesinger Oct 23, 2026
b71031e
ci(hygiene): run the source hygiene check with simp checking
SamuelSchlesinger Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/lean_action_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
- uses: actions/checkout@v4
- name: Test documentation checker
run: python3 -m unittest discover -s scripts -p 'test_*.py'
- name: "Source hygiene"
run: python3 -B scripts/check_hygiene.py --check-simp
- uses: leanprover/lean-action@v1
with:
build-args: "--wfail --iofail @complexitylib @mathlib/mk_all @/checkInitImports @mathlib/lint-style"
Expand Down
5 changes: 4 additions & 1 deletion Complexity/Computability/Circuit/Boolean/CarryLookahead.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ def step (k distance : ℕ) : Circuit signature (k + k) (k + k) :=
(Circuit.pi fun i => (propagateFormula k distance i).toCircuit)

@[simp] theorem size_step (k distance : ℕ) : (step k distance).size = 3 * k := by
simp [step, generateFormula, propagateFormula, Formula.size_toCircuit]
simp only [step, generateFormula, Fin.natAdd_eq_addNat, propagateFormula, Circuit.size_append,
Circuit.size_pi, Formula.size_toCircuit, Formula.size_or, Formula.size_input, Formula.size_and,
add_zero, zero_add, Nat.reduceAdd, Finset.sum_const, Finset.card_univ, Fintype.card_fin,
smul_eq_mul, mul_one]
omega

theorem depth_step_le (k distance : ℕ) : (step k distance).depth ≤ 2 := by
Expand Down
Loading