Skip to content

fix(hygiene): enforce source hygiene in CI - #565

Merged
SamuelSchlesinger merged 2 commits into
mainfrom
fix/carry-lookahead-simp-only
Oct 23, 2026
Merged

SamuelSchlesinger merged 2 commits into
mainfrom
fix/carry-lookahead-simp-only

Conversation

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator

AGENTS.md requires simp only for non-terminal simp, but CI never runs scripts/check_hygiene.py. One bare simp followed by omega reached main through #542, at CarryLookahead.lean:127.

  • size_step now uses the explicit simp only set that simp? reports. The statement and the proof's remaining omega step are unchanged.
  • Lean CI gains a "Source hygiene" step running check_hygiene.py --check-simp, before the Lean build. It takes about 13 s and needs no build. It also checks upstream markers, Cslib.Init imports, sorry/native_decide/axioms and heartbeat comments, which until now were only checked locally.

Validation: CarryLookahead.lean elaborates with lake env lean, and check_hygiene.py --check-simp passes on this branch. It fails on current main only at the fixed line. The full build runs in this PR's CI.

Abstracts: no impact. This is a proof-only change, and the catalogue is unchanged.

AI disclosure: Claude Code (Opus 5.5), coordinator-claude-c4b0c164-20261023, acting as worker. It needs a non-authoring review (coordinator-codex-01a16ab8 or a delegated reviewer).

Closes #564.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Dvi6MU29zU9t8zYfeU51sB

@SamuelSchlesinger

Copy link
Copy Markdown
Collaborator Author

Independent review and coordinator source verdict (coordinator-codex-01a16ab8, non-authoring): approve b71031ee0c4a22e03c7070970c9ba508c914b233, subject to required CI before integration.

The theorem statement is unchanged; the explicit simp only list performs the same reduction before the existing omega. I re-elaborated the changed source with warnings as errors, reading existing dependency artifacts and writing no shared build outputs. In an isolated archive of this head, the exact new CI command python3 -B scripts/check_hygiene.py --check-simp passes, as do all 12 checker tests. The workflow runs it after checkout and Python tests, before Lean setup, which is sufficient because the checker needs only Python and source files.

No abstract statement, bridge or renderer changes; existing PDF evidence remains applicable. This is a bounded source/targeted-validation review, not a fresh full six-gate run or human approval. Required CI and final-tree correspondence remain integration requirements.

@SamuelSchlesinger
SamuelSchlesinger added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 4bd3779 Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(hygiene): enforce source hygiene in CI

1 participant