Skip to content

CLARIN-DSpace v9: redirect anonymous bitstream download on the server too #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 1 commit into from
Oct 22, 2026
Merged

CLARIN-DSpace v9: redirect anonymous bitstream download on the server too #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ream-page/clarin-bitstream-download-page/clarin-bitstream-download-page.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,14 +211,15 @@ describe('ClarinBitstreamDownloadPageComponent', () => {
expect(component.redirectToContent).not.toHaveBeenCalled();
});

it('should download with the dtoken and the access token once the CLARIN check passes', () => {
it('should redirect an anonymous user through HardRedirectService with the dtoken and the access token once the CLARIN check passes', () => {
rdbService.buildFromRequestUUID.and.returnValue(of(createSuccessfulRemoteDataObject({})));
activatedRoute.snapshot.queryParams = { dtoken: dtoken, accessToken: accessToken };

component.ngOnInit();

expect(component.redirectToContent).toHaveBeenCalledWith(
expect(hardRedirectService.redirect).toHaveBeenCalledWith(
contentHref + '?dtoken=' + dtoken + '&accessToken=' + accessToken);
expect(component.redirectToContent).not.toHaveBeenCalled();
});

it('should download through the file link with the access token for a logged-in user', () => {
Expand Down Expand Up @@ -266,7 +267,8 @@ describe('ClarinBitstreamDownloadPageComponent', () => {
component.ngOnInit();

expect(clarinCheckUrl()).toEqual('rest-api/authrn/bitstreamUuid?dtoken=' + dtoken);
expect(component.redirectToContent).toHaveBeenCalledWith(contentHref + '?dtoken=' + dtoken);
expect(hardRedirectService.redirect).toHaveBeenCalledWith(contentHref + '?dtoken=' + dtoken);
expect(component.redirectToContent).not.toHaveBeenCalled();
});

it('should send an anonymous user without an access token to the login page', () => {
Expand Down
4 changes: 3 additions & 1 deletion ...bitstream-page/clarin-bitstream-download-page/clarin-bitstream-download-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ export class ClarinBitstreamDownloadPageComponent implements OnInit {
this.redirectToContent(fileLink);
} else if ((isAuthorized || isAuthorizedByClarin) && !isLoggedIn) {
this.downloadStatus.next(RequestEntryState.Success);
this.redirectToContent(bitstreamURL);
// Server-side too, so crawlers get a 302. Logged-in users keep the client-side
// redirect: a server 302 right after login left the browser on the login page.
this.hardRedirectService.redirect(bitstreamURL);
} else if (!(isAuthorized || isAuthorizedByClarin) && isLoggedIn &&
this.downloadStatus.value === (RequestEntryState.Error as string)) {
// this.downloadStatus is `ERROR` - no CLARIN exception is thrown up
Expand Down
Loading