Repository navigation
fix: configure notification Kafka consumer - #9
Merged
Merged
Conversation
This was referenced Sep 4, 2026
Member
Author
Audit follow-up (2026-09-05)The audit found one deployment-critical omission in this PR: Commit Verification:
After merge, rebuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsumerFactoryrequired by the transfer-created listener.0.0.2image workflow.Why
The Notification Service SIT deployment reaches PostgreSQL and completes Flyway migration, then fails during context creation because the custom listener container factory requires a
ConsumerFactory<String, String>that is not provided. The listener remains opt-in and existing retry/quarantine behavior is unchanged.Verification
./mvnw --batch-mode --no-transfer-progress verifypassed.helm lint helm --strict --values helm/values-sit.yamlpassed.git diff --checkpassed.Project tracking
This is a local SIT rollout fix. UAT/PROD implementation remains deferred.
Merge and rollout
This PR is independent of the Payment PR and can merge in either order; no delay is required. After merge, build
digital-bank-java/notification-service:0.0.2, upgrade the SIT release, and verify health and Kafka listener startup before closing bug #221.