Skip to content

fix: configure notification Kafka consumer - #9

Merged
ramioooz merged 2 commits into
mainfrom
fix/221-notification-kafka-consumer
Sep 5, 2026
Merged

ramioooz merged 2 commits into
mainfrom
fix/221-notification-kafka-consumer

Conversation

@ramioooz

@ramioooz ramioooz commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Define the explicit String-key/String-value Kafka ConsumerFactory required by the transfer-created listener.
  • Apply the configured broker, group, offset, commit, and deserializer settings.
  • Bump chart metadata and document the 0.0.2 image workflow.

Why

The Notification Service SIT deployment reaches PostgreSQL and completes Flyway migration, then fails during context creation because the custom listener container factory requires a ConsumerFactory<String, String> that is not provided. The listener remains opt-in and existing retry/quarantine behavior is unchanged.

Verification

  • ./mvnw --batch-mode --no-transfer-progress verify passed.
  • Existing tests and the integration suite passed.
  • helm lint helm --strict --values helm/values-sit.yaml passed.
  • Container smoke test passed.
  • git diff --check passed.

Project tracking

This is a local SIT rollout fix. UAT/PROD implementation remains deferred.

Merge and rollout

This PR is independent of the Payment PR and can merge in either order; no delay is required. After merge, build digital-bank-java/notification-service:0.0.2, upgrade the SIT release, and verify health and Kafka listener startup before closing bug #221.

@ramioooz

ramioooz commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Audit follow-up (2026-09-05)

The audit found one deployment-critical omission in this PR: helm/Chart.yaml and the README referenced 0.0.2, but the default helm/values.yaml image tag remained 0.0.1. Because values-sit.yaml inherits that tag, a normal SIT upgrade could redeploy the pre-fix image.

Commit 45a6be7 aligns the default image tag to 0.0.2. No other scope was changed.

Verification:

  • Current main with transfer-event consumption enabled fails context creation because no ConsumerFactory<String, String> exists.
  • This PR branch with consumption enabled and listener auto-start disabled starts the Spring context and passes all 6 NotificationServiceApplicationIT checks.
  • Helm lint and SIT rendering pass; the rendered image is digital-bank-java/notification-service:0.0.2.
  • No secrets were printed or added.

After merge, rebuild digital-bank-java/notification-service:0.0.2, reconcile/upgrade the SIT release, and verify the pod is Ready with zero restarts and the notification-service consumer group is active. Close .github#221 only after that permanent mainline rollout evidence is recorded.

@ramioooz
ramioooz merged commit 6eaf601 into main Sep 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant