Skip to content

feat: integrate payment instruction lifecycle - #6

Merged
ramioooz merged 10 commits into
mainfrom
feature/98-payment-service-integration
Sep 3, 2026
Merged

ramioooz merged 10 commits into
mainfrom
feature/98-payment-service-integration

Conversation

@ramioooz

@ramioooz ramioooz commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

Integrate the reviewed Payment Service stack into main: payment instruction lifecycle, PostgreSQL persistence, idempotency, internal authorization, HTTP resource contract, Problem Details, Helm, and CI.

This PR is non-draft and does not merge directly to main.

Related work

Those PRs were merged into successive feature branches, so this integration PR is required to place the complete stack on main.

Verification

  • ./mvnw --batch-mode --no-transfer-progress verify
  • Spotless passed.
  • 16 tests passed.
  • PostgreSQL/Testcontainers integration tests passed.
  • git diff --check passed.

Merge guidance

Merge after review. config-repo#34 may merge before or after this PR; no delay is required. Roll out Payment Service only after the service and SIT configuration are available.

@ramioooz

ramioooz commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Deployment-readiness review: please do not treat this PR as the final SIT rollout yet.

The merged implementation requires follow-up tracked in .github#199:

  • Helm does not currently inject the Payment PostgreSQL datasource URL or credentials.
  • Payment JWT validation must be aligned with the platform Auth contract and required internal scope.
  • The lifecycle implementation needs a new immutable image tag rather than reusing the bootstrap tag.

The PR's Maven, Helm, and container checks are useful, but they do not prove a real SIT deployment. config-repo#34 is also only basic service metadata and must be expanded or paired with the runtime-wiring change. Merge order should be the runtime fix first, then config, then build and deploy; no rollout delay is required after both are on main.

@ramioooz
ramioooz merged commit 70ab1fe into main Sep 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant