Repository navigation
Build the dictionary test's indices with a 64 bit arange - #705
Merged
evertlammerts merged 1 commit intoOct 20, 2026
Merged
evertlammerts merged 1 commit into
evertlammerts merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the cp311 Windows wheel job of the Release workflow, which fails every run since #700 in
test_a_dictionary_is_decoded_once_per_large_batchbefore any DuckDB code runs:The test builds its dictionary indices as
np.arange(2_000_000) * 1_000_000 // 2_000_000. On Windows with numpy below 2,np.arangedefaults to int32 (the Clong), so the product overflows and about half the indices come out negative. The cp311 job is the only Windows job that installs numpy below 2 (the tensorflow pin), which is why neither the PR workflow nor the other wheel jobs saw it. An int32 simulation gives the same minimum of -1074.The arange now carries
dtype=np.int64. Same class as #696; the othernp.arangecalls in the tests are small, float, or typed.