Skip to content

Build the dictionary test's indices with a 64 bit arange #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evertlammerts merged 1 commit into from
Oct 20, 2026
Merged

Build the dictionary test's indices with a 64 bit arange #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/fast/arrow/scan/test_arrow_scan_row_ranges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,9 @@ def test_run_ends_that_change_between_large_batches(self, threads):
def test_a_dictionary_is_decoded_once_per_large_batch(self):
values = pa.array([f"value-{i:08d}" for i in range(DICTIONARY_VALUES)])
# In order, since random indices into a large dictionary make the time depend on the machine's caches.
indices = pa.array((np.arange(DICTIONARY_ROWS) * DICTIONARY_VALUES // DICTIONARY_ROWS).astype(np.int32))
indices = pa.array(
(np.arange(DICTIONARY_ROWS, dtype=np.int64) * DICTIONARY_VALUES // DICTIONARY_ROWS).astype(np.int32)
)
whole = pa.table({"d": pa.DictionaryArray.from_arrays(indices, values)})
# Each slice keeps the whole dictionary, which the scan decodes again for every batch because it drops the
# decoded dictionary when the batch changes.
Expand Down
Loading