Repository navigation
refactor: the stock bundle no longer binds the @viewer opener - #141
Merged
Merged
Conversation
wfpy-ide's own bundle binds its copy of the @viewer node opener (endrix/wfpy-ide#29), under the same id, so the platform's copy goes: viewer-node-opener.ts, its binding in the stock feature module, and the two route test files that moved to wfpy-ide with it. The double-click listener keeps the NodeOpener point and opens a node's definition for every product; double-click-opens-one-thing, which pins that, stays and needs no opener now. The parity baseline loses the one binding; the seam's DI tests pin that the stock diagram binds no opener. The host still turns the wf:viewer* arguments of the opener's actions into an editor, a diff or a command; that half is next. wfpy-ide's branch passes its 154 tests against this tree. Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
endrix/wfpy-ide#29 (merged) has wfpy-ide's bundle bind its own copy of the opener under the same id.
What
viewer-node-opener.ts, its binding in the stock feature module, and the two route test files that moved to wfpy-ide with it.NodeOpenerpoint and opens a node's definition for every product.double-click-opens-one-thing, which pins that, stays and needs no opener now.@viewertasks, so nothing changes for them. The stock bundle no longer contains the opener.wf:viewer*arguments of the opener's actions into an editor, a diff or a command. That half is next.Review (
/code-review medium)The review found no correctness bug and no leftover reference to the deleted opener or tests. It also confirmed, by searching hdl-sidecar, streamblocks-ide, sb-calpy, ndf-ide, chisel-ide, sv/vhdl-ide and mlir-viewer, that no product other than wfpy emits
@viewer. The edge last-token opener stays in the platform, since sv/vhdl use it.wf:viewer*argument keys from@dialogram/shared, so the host and wfpy-ide's opener share one contract.ViewerMouseListener, which no longer has anything to do with viewers, in the P6 vocabulary pass.Local results
https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv