Skip to content

refactor: the stock bundle no longer binds the @viewer opener - #141

Merged
endrix merged 1 commit into
mainfrom
refactor/stock-without-viewer-opener
Nov 9, 2026
Merged

endrix merged 1 commit into
mainfrom
refactor/stock-without-viewer-opener

Conversation

@endrix

@endrix endrix commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

endrix/wfpy-ide#29 (merged) has wfpy-ide's bundle bind its own copy of the opener under the same id.

What

  • The platform's copy goes: viewer-node-opener.ts, its binding in the stock feature module, and the two route test files that moved to wfpy-ide with it.
  • What stays: the double-click listener keeps the NodeOpener point and opens a node's definition for every product. double-click-opens-one-thing, which pins that, stays and needs no opener now.
  • Effect: sv, vhdl, ndf and calpy never had @viewer tasks, so nothing changes for them. The stock bundle no longer contains the opener.
  • Tests:
    • Container parity loses the one binding.
    • The seam's DI tests now pin that the stock diagram binds no opener, plus a later module's opener replacing an earlier one's.
  • Still in the platform: the host still turns the wf:viewer* arguments of the opener's actions into an editor, a diff or a command. That half is next.

Review (/code-review medium)

The review found no correctness bug and no leftover reference to the deleted opener or tests. It also confirmed, by searching hdl-sidecar, streamblocks-ide, sb-calpy, ndf-ide, chisel-ide, sv/vhdl-ide and mlir-viewer, that no product other than wfpy emits @viewer. The edge last-token opener stays in the platform, since sv/vhdl use it.

Local results

  • client suite: 402/402
  • typecheck: 5/5
  • neutrality: 5/5
  • build: OK
  • wfpy-ide#29's branch against this tree: 154/154

https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv

wfpy-ide's own bundle binds its copy of the @viewer node opener
(endrix/wfpy-ide#29), under the same id, so the platform's copy goes:
viewer-node-opener.ts, its binding in the stock feature module, and the
two route test files that moved to wfpy-ide with it. The double-click
listener keeps the NodeOpener point and opens a node's definition for
every product; double-click-opens-one-thing, which pins that, stays and
needs no opener now. The parity baseline loses the one binding; the
seam's DI tests pin that the stock diagram binds no opener.

The host still turns the wf:viewer* arguments of the opener's actions
into an editor, a diff or a command; that half is next.

wfpy-ide's branch passes its 154 tests against this tree.

Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
@endrix
endrix merged commit 0cd6e3c into main Nov 9, 2026
1 check passed
endrix added a commit that referenced this pull request Nov 9, 2026
…ase reads it (#142)

What the review of #141 asked for and #141 merged without: the removal
under Removed, and #141 in the release note's list of what needs the 0.9
bump, as #137 is.

Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant