Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ version check rather than run against what it no longer has.
definition navigation, or leaves the node to it; one per `id`, the last
binding winning. The `@viewer` half of the double-click listener (open,
diff, open with an editor or run a command on a task's last tokens, or a
path it declares) is the `viewer` opener (`viewer-node-opener.ts`), which
the stock module binds until wfpy-ide binds its own.
path it declares) became the `viewer` opener (#140) and then wfpy-ide's
code, in its own bundle (endrix/wfpy-ide#29); the stock bundle binds no
opener.

- **What a product's webview code needs, from the package.**
`@dialogram/diagram-client` exports `VscodeUi` (the host's quick picks,
Expand Down
3 changes: 1 addition & 2 deletions packages/diagram-client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,7 @@ of your nodes, bind a `NodeOpener` with an `id`: its `open(node, { sourceUri })`
returns the actions to run, or `undefined` to leave the node to the platform.
Openers are asked in the order their ids were first bound, and the first
that answers wins; a later binding for an id replaces the earlier one. The
stock bundle binds wfpy's `@viewer` opener (id `viewer`) until wfpy-ide binds
its own.
stock bundle binds none; wfpy-ide's binds its `@viewer` opener.

**A diagram of your own.** When you compose the container yourself:

Expand Down
5 changes: 0 additions & 5 deletions packages/diagram-client/src/stock-features.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import { clientBehavior } from './profile';
import { WorkflowNavigationUi } from './navigation-ui';
import { WorkflowNetworkNavigationMouseListener } from './network-navigation-mouse-listener';
import { ViewerMouseListener } from './viewer-mouse-listener';
import { NodeOpener } from './node-opener';
import { ViewerNodeOpener } from './viewer-node-opener';
import { EdgeOpenMouseListener } from './edge-open-mouse-listener';
import { WhitespaceRootPropertiesMouseListener } from './whitespace-root-properties-mouse-listener';
import { WorkflowElkLiveDragRouter } from './elk-live-drag-router';
Expand Down Expand Up @@ -116,9 +114,6 @@ export const workflowFeaturesModule = new ContainerModule((bind, unbind, isBound
// Double-click on a node: what a product's openers open for it, else its
// definition (every product relies on the latter).
bindAsService(context, TYPES.MouseListener, ViewerMouseListener);
// What a double-click on a `@viewer` task opens (its last tokens), until
// the product that has `@viewer` binds it in its own bundle.
bind(NodeOpener).toConstantValue(new ViewerNodeOpener());

// Double-click on diagram whitespace to show root/workflow properties.
bindAsService(context, TYPES.MouseListener, WhitespaceRootPropertiesMouseListener);
Expand Down
Loading
Loading