Repository navigation
conformance: drop the solc resources stamp workaround - #405
Merged
Merged
Conversation
solc now emits the `ethdebug` stamp on its resources object, so the solc tests validate its artifact as it is. Closes #311
Contributor
|
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solc now emits the
ethdebugstamp on its resources object itself, so the conformance tests no longer need to add it before they validate solc's artifact. This removeswithSolcResourcesStampand validates the artifact as solc writes it.The SolDB test ("checks solc ETHDebug resources through the SolDB consumer backend") still fails: SolDB drops keys it does not know when it reads bare resources, so the stamp does not reach it. That is handled separately.
Closes #311