Repository navigation
chore(deps): bump toml and toml_writer, refreshing their publisher facts - #2884
Conversation
Takes the half of #2880 that can land. toml 1.1.8 -> 1.2.0 and toml_writer 1.1.3 -> 1.2.0, with the imports.lock publisher facts the bump needs. imports.lock records a publisher fact per exact version, so a bump leaves the new one unattested and `cargo vet --locked` fails with "N unvetted dependencies" — which is what the Audit job reported on #2880. CI only ever runs the locked form, so it can never record the facts itself; a non-locked `cargo vet` is the only thing that does, and Dependabot does not run one. This recurs on every group bump that moves a trusted publisher's crate. Both facts are fetched from crates.io, not written here: epage, 2026-11-04 for each. The run also re-aggregated Mozilla's utf8_iter wildcard audit, which moved upstream; that hunk is incidental to refreshing imports, not a change of our own. russh 0.65.1 and signal-hook 0.4.6 are deliberately left out. Both sit on delta-audit chains (russh 0.63.3 -> 0.64.1 -> 0.65.0, signal-hook 0.4.4 -> 0.4.5) whose entries are human source-safety reviews, so each needs a new delta audit rather than an exemption. Writing those here would assert a review that did not happen. Claude-Session: https://claude.ai/code/session_01Wy7MByvAMwapenBYpmq9HN
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 54f1f7f | Commit Preview URL Branch Preview URL |
Nov 07 2026, 02:52 PM |
Review summary (PR #2884)Verdict: No findings — this is a routine, well-formed automated dependency bump. Lockfile-only change ( What I verified beyond the diff:
Not reviewed / limits: I did not build or run tests — this shell has no cargo/network ( |
What changed
toml1.1.8 → 1.2.0 andtoml_writer1.1.3 → 1.2.0, together with theimports.lockpublisher facts the bump needs.This is the half of #2880 that can land.
russh0.65.1 andsignal-hook0.4.6 are deliberately left out — see below.Why
#2880's
Auditjob failed with:imports.lockrecords a publisher fact per exact version, so any bump of a trusted publisher's crate leaves the new version unattested. CI only ever runscargo vet --locked, which cannot fetch facts; a non---lockedrun is the only thing that records them, and Dependabot never does one. So this is not a one-off — it will fail the same way on every group bump that moves such a crate, which is worth knowing independently of this PR.The two facts here are fetched from crates.io, not authored in this PR —
epage, 2026-11-04 for both.Before / After
Also in the diff, both incidental rather than changes of ours:
imports.lockre-aggregated Mozilla'sutf8_iterwildcard audit, which changed upstream (who/end/notes).Cargo.lockre-picked whichsyncssparser-macrosresolves to (3.0.9→2.0.119) — ordinarycargo updateresolver churn; both majors are already in the tree withsafe-to-deployexemptions, andcargo check --workspace --all-targetsis clean.I under-described this diff when I opened the PR (I named only the two publisher facts and the Mozilla hunk); the
synre-pick was caught in review and is listed here for completeness.What I did NOT do, and why it needs you
russhandsignal-hookare not on exemptions — they sit on delta-audit chains whose entries are human source-safety reviews:russh:0.63.3 → 0.64.1 → 0.65.0signal-hook:0.4.4 → 0.4.5Every audit in
audits.tomlis authored by you. Landing 0.65.1 / 0.4.6 therefore needs a new delta audit each —cargo veteven sizes them (russh15 files, +388/−49;signal-hook4 files, +70/−12).I did not write those, and did not substitute exemptions for them. Writing an audit would assert a source review that did not happen, in your name; swapping in an exemption would quietly downgrade an SSH implementation reached over the network from audited to accepted-unaudited without you deciding that. Either is your call, not mine.
To land them:
Dependabot will keep re-proposing both until then.
Risk
toml/toml_writerare the TOML parser/writer already in the tree, moving one minor version from the same publisher.cargo check --workspace --all-targetsclean, 263 repo-script tests green,cargo vet --lockedgreen.Checklist
cargo vet --lockedpasses (reproduced the failure first, then fixed it)Part of #2880.
Generated by Claude Code
<a href="
https://backend.blacksmith.sh/track/enable-autofix?expires=1796655045&installation_model_id=447267&pr_number=2884&ref=codesmith_pr_footer&repository=everruns%2Fbashkit&return_to=https%3A%2F%2Fgithub.com%2Feverruns%2Fbashkit%2Fpull%2F2884&signature=92a5dbe2a1bc309f11fdf7590d5fe0e39ec4aceb3a93cf7f86cf8f61eb26108e"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark-3x.png" width="190" height="28">Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Generated by Claude Code