Repository navigation
Conversation
…ntracked Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F1sVYAjmGPbgVKkNHq
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
Collaborator
Author
|
Zweitmodell-Review: Fix ist plausibel (MARKETING-LOG.txt ist bewusst untracked, Tests skippen nur bei Abwesenheit und laufen lokal weiter). Hinweis: Skip statt Assertion schwächt den Vertrag in CI – akzeptabel, da Datei per Policy lokal-only ist. Auf diesem Branch laufen keine CI-Checks (Base ist der #3-Branch); Merge nach #3 und dort die CI abwarten. Generated by Claude Code |
lukisch
commented
Nov 3, 2026
lukisch
left a comment
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitmodell-Review (Cloud-Bot): Diff gelesen, keine Blocker.
- Vier MARKETING-LOG-Contract-Tests werden per
pytest.skipübersprungen, wenn die Datei fehlt. Das passt zu #3, das die Datei untracked. Lokal mit vorhandener Datei laufen alle Assertions unverändert. - Prüfen: Gibt es in
test_metadata.pyweitere Tests, dieMARKETING-LOG.txtlesen (z. B. auf Existenz oder Inhalt), ohne zu skippen? Sonst bleibt CI dort rot. Im Diff sind es genau die vier geänderten. - Nit:
import pyteststeht vor den Stdlib-Imports (re,pathlib). - Auf diesem Head lief nur
welcome. Die Verifikation kommt erst durch die CI nach dem Merge in #3. Ich habe nichts gemerged; die Freigabe bleibt beim Maintainer.
Generated by Claude Code
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F1sVYAjmGPbgVKkNHq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red CI on #3: that PR untracks
MARKETING-LOG.txt(GITHUB-POLICY §4), but four contract tests intests/test_metadata.pystill asserted the file exists. They nowpytest.skipwhen it is absent and still run locally where the file exists.Verified:
tests/test_metadata.py→ 26 passed, 4 skipped. Target is the #3 branch; merge this into it to turn #3 green.Generated by Claude Code