Repository navigation
Conversation
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
ellmos-multi-bot
left a comment
There was a problem hiding this comment.
Independent review of c287445 — Codex (GPT-6), separate reviewer instance. Full five-file diff and complete EN/DE/ES guides checked against the desktop implementation, export code, Companion parser, package metadata and translation catalog.
The language links, six-locale distinction and current test paths are consistent. The new Spanish guide also republishes functional instructions that do not match this head:
- [P2] README_es.md:296-297: desktop drag-and-drop and a table sidebar are described, but SqlViewer uses a toolbar Combobox and registers no desktop drop handler. Please document Ctrl+O/File Open and the toolbar selector; these are distinct from dropping JSON into the web Companion.
- [P2] README_es.md:301: Ctrl+E does not offer CSV/JSON selection. The actual menu builder binds it to export_csv, whose save dialog offers CSV and All Files only. JSON is a separate menu action / Ctrl+Shift+E. Following the guide cannot produce the JSON required for the next workflow. Please correct the instructions and shortcut table, including the existing EN/DE copies.
- [P2] README_es.md:349: the unconditional export-to-Companion handoff omits enforced limits: 8 MiB, 100 columns, 2,000 rows. Desktop SQL export has no automatic 2,000-row limit. The actual parser rejects 2,001 rows with IMPORT_TOO_MANY_ROWS. Document these bounds and how to limit/split the export before promising that an exported file can be inspected.
Own checks used a synthetic DB only, without constructing a Tk window: actual read-only connection and unchanged DB hash; table limit and literal wildcard filtering; query export; CSV formula neutralization and Base64 BLOBs; actual menu callbacks/dialog format options. All three guide JSON examples are identical and parse in the actual Companion library; the over-limit rejection was reproduced with Node. Translation check: 86 keys across six locales. Diff check passed. No new full-pytest, browser/device, Store or live-user-data acceptance is claimed.
This is a COMMENT on a Draft, not approval. The Draft should remain unready until the documentation paths are corrected.
|
Zweitmodell-Review (Cloud-Bot): Docs-only, Mergestatus clean.
Kein Blocker. Merge bleibt beim Maintainer. Generated by Claude Code |
Summary
Verification
Documentation-only change; no runtime or Store changes.