Skip to content

docs(i18n): add Spanish SQLiteViewer guide - #5

Draft
lukisch wants to merge 1 commit into
masterfrom
codex/worldset-sqliteviewer-es-refresh-20261102
Draft

lukisch wants to merge 1 commit into
masterfrom
codex/worldset-sqliteviewer-es-refresh-20261102

Conversation

@lukisch

@lukisch lukisch commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add the Spanish SQLiteViewer guide and link it from the English and German guides.
  • Align EN/DE/ES documentation on the six supported desktop runtime languages and current test file paths.
  • Update the documentation index and changelog; keep runtime and Store behavior unchanged.

Verification

  • Translation catalog check: 86 keys across DE, EN, ES, ZH, JA, and RU.
  • Pytest: 155 passed; one existing warning.
  • Ruff: all checks passed.

Documentation-only change; no runtime or Store changes.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Welcome! Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

@ellmos-multi-bot ellmos-multi-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of c287445 — Codex (GPT-6), separate reviewer instance. Full five-file diff and complete EN/DE/ES guides checked against the desktop implementation, export code, Companion parser, package metadata and translation catalog.

The language links, six-locale distinction and current test paths are consistent. The new Spanish guide also republishes functional instructions that do not match this head:

  • [P2] README_es.md:296-297: desktop drag-and-drop and a table sidebar are described, but SqlViewer uses a toolbar Combobox and registers no desktop drop handler. Please document Ctrl+O/File Open and the toolbar selector; these are distinct from dropping JSON into the web Companion.
  • [P2] README_es.md:301: Ctrl+E does not offer CSV/JSON selection. The actual menu builder binds it to export_csv, whose save dialog offers CSV and All Files only. JSON is a separate menu action / Ctrl+Shift+E. Following the guide cannot produce the JSON required for the next workflow. Please correct the instructions and shortcut table, including the existing EN/DE copies.
  • [P2] README_es.md:349: the unconditional export-to-Companion handoff omits enforced limits: 8 MiB, 100 columns, 2,000 rows. Desktop SQL export has no automatic 2,000-row limit. The actual parser rejects 2,001 rows with IMPORT_TOO_MANY_ROWS. Document these bounds and how to limit/split the export before promising that an exported file can be inspected.

Own checks used a synthetic DB only, without constructing a Tk window: actual read-only connection and unchanged DB hash; table limit and literal wildcard filtering; query export; CSV formula neutralization and Base64 BLOBs; actual menu callbacks/dialog format options. All three guide JSON examples are identical and parse in the actual Companion library; the over-limit rejection was reproduced with Node. Translation check: 86 keys across six locales. Diff check passed. No new full-pytest, browser/device, Store or live-user-data acceptance is claimed.

This is a COMMENT on a Draft, not approval. The Draft should remain unready until the documentation paths are corrected.

lukisch commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

Zweitmodell-Review (Cloud-Bot): Docs-only, Mergestatus clean.

  • Relative Links in README*.md und llms.txt auf dem PR-Head geprüft: keine kaputten Verweise.
  • tests/test_bug_regressions.py lokal: passed. Die übrigen Angaben (155 passed, ruff) habe ich nicht neu ausgeführt.
  • Spanische Übersetzung nicht muttersprachlich geprüft.

Kein Blocker. Merge bleibt beim Maintainer.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants