Sync the shared review stopping rules - #49
Merged
Merged
Conversation
The commit, pull request, review, and landing rules are shared with firstdraft/firstdraft and firstdraft/skills, and the service repository is changing two of them to cut duplicate review sessions. An amendment that only applies accepted findings no longer needs a re-review, and a review whose only trigger is an instruction-policy change runs once at high effort instead of max. Keep this copy in step so following it does not bring the extra sessions back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The commit, pull request, review, and landing rules are shared across
firstdraft/firstdraft,firstdraft/cli, andfirstdraft/skills. The service repository is changing two of them to cut duplicate review sessions:--effort highinstead ofmax.This keeps this copy in step, so following it does not bring the extra sessions back. This repository's own review triggers are unchanged.
Docs: updated CONTRIBUTING.md.
Review: codex-review 0.7.3, high effort, session
35ddc7e9-d56a-41e6-9f82-4e91b2c58ef3, approve.