Skip to content

Sync the shared review stopping rules #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghubetina merged 1 commit into from
Oct 1, 2026
Merged

Sync the shared review stopping rules #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ codex plugin add claude-review@cross-review
To run a review:

1. Start a `new` session over the branch, such as `new branch main`, or over an explicit range with
`new range <base>..<head>`.
`new range <base>..<head>`. When an instruction-policy change is the only reason for review, run that one session
with `--effort high` instead of the default `max`.
2. Pass the service repository's `docs/review-focus.md` with `--focus-file`, from a sibling `firstdraft/firstdraft`
checkout or fetched into the ignored `tmp/`:

Expand All @@ -84,8 +85,9 @@ To run a review:

3. When the review finishes, the host agent runs `cite` and checks each finding against the cited lines before
relaying it.
4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Review an amendment
in the same session with `range <reviewed-head>..HEAD`.
4. Record each decision after `--` as `reject F-...: reason`, `accept F-...`, or `defer F-...`. Re-review an
amendment only when it does more than apply accepted findings, in the same session with
`range <reviewed-head>..HEAD`.

Do not merge while a required review is still running. Review third-party changes, such as Dependabot or outside
pull requests, with `--capability read-only`.
Expand Down
Loading