Repository navigation
fix: read more bug fix on safari - #1152
santipalenque wants to merge 1 commit into
Conversation
|
/deploy-preview |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
🚀 Deployed on https://pr-1152--show-admin-preview.netlify.app |
There was a problem hiding this comment.
🔵 Needs a closer look
Safari/WebKit validation is still needed for text visibility, toggle alignment, and resize/collapse behavior because the jsdom tests mock geometry and cannot verify the browser-specific layout fix.
No open issues 🎉
What changed in this PR
This PR addresses Safari rendering issues in the shared ExpandText component by moving the “Read more” toggle outside the clamped text.
Changes:
- Replaces the floated toggle and spacer with a separate, bottom-aligned flex item.
- Lets the text area shrink while preserving the toggle’s width.
| File | Description |
|---|---|
src/components/mui/ExpandText/index.jsx |
Separates the toggle from the clamped text and adjusts flex sizing and alignment. |
Review effort: Balanced
https://app.clickup.com/t/9014802374/86bd2dtbx
Summary by CodeRabbit