Skip to content

fix: read more bug fix on safari #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santipalenque wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: read more bug fix on safari #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/components/mui/ExpandText/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,27 +77,25 @@ const ExpandText = ({ children, lines = DEFAULT_LINES, charCount }) => {
);
}

// flex parent gives the clamped box a definite height so the ::before spacer can use 100%
// toggle sits beside the clamp, not floated inside it: Safari blanks clamped text that wraps a float
return (
<Box sx={{ display: "flex", overflowWrap: "anywhere" }}>
<Box
sx={{ display: "flex", alignItems: "flex-end", overflowWrap: "anywhere" }}
>
<Box
ref={textRef}
sx={{
flex: 1,
minWidth: 0,
display: "-webkit-box",
WebkitLineClamp: lines,
WebkitBoxOrient: "vertical",
overflow: "hidden",
// spacer float pushes the toggle down to the last visible line, so the ellipsis lands before it
"&::before": {
content: "\"\"",
float: "right",
height: "calc(100% - 1lh)"
}
overflow: "hidden"
}}
>
{isClamped && renderToggle({ float: "right", clear: "both", ml: 0.5 })}
{text}
</Box>
{isClamped && renderToggle({ flexShrink: 0, ml: 0.5 })}
</Box>
);
};
Expand Down
Loading