You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(deps): update uicore to 5.0.75 and adjust for row actions - #1153
Bumps openstack-uicore-foundation from 5.0.73-beta.1 to 5.0.75 (latest 5.0.x) and updates summit-admin for the row actions menu that 5.0.74 introduced (OpenStackweb/openstack-uicore-foundation#380), which replaces MuiTable's Edit and Delete icon columns with a single ⋮ menu.
Cart total row:cart-view computes colGap/trailing from the column count MuiTable now passes to a function child, so the total stays under Amount (editable cart: 9 columns, read-only: 7).
Removed options={{ responsive: false }} from cart-view. uicore no longer reads it.
Tests: cart view, show pages list, sponsor forms tab and sponsor pages tab open the ⋮ menu and pick Edit/Delete by name, instead of clicking action-edit/action-delete or the EditIcon/DeleteIcon buttons.
The cart-view and test changes are the commit from #1147 by @ako3131, cherry-picked unchanged. This PR adds the version bump that #1147 was waiting on. The two have to land together: on 5.0.73-beta.1 MuiTable renders children as-is, so the function child renders no total row.
Once this merges, #1141 can drop its own uicore bump and rebase onto it.
Tests
yarn jest (full run, local): 2233 of 2243 pass. The 10 failures are 5000 ms timeouts in five suites unrelated to this change (event-form, event-form-notify, page-template-popup, delete-extra-question-popup, process-request-popup), hit while the machine was under load. All 74 tests in those suites pass with --runInBand on both 5.0.75 and 5.0.73-beta.1.
The four updated suites (show-pages-list-page, cart-view, sponsor-forms-tab, sponsor-pages-tab) pass on 5.0.75.
eslint on the changed files: 0 errors.
Summary by CodeRabbit
Bug Fixes
Cart totals now align with the amount column and table width in both editable and non-editable carts, keeping the total row consistent across cart types. This improves the readability of cart amounts and totals when viewing sponsor carts, regardless of whether editing is available.
5.0.74 and later replace the MuiTable Edit and Delete icon columns with a
row actions menu and pass the column count to a function child, which the
cart total row and the sponsor table tests rely on.
No actionable comments were generated in the recent review.
Walkthrough
Sponsor page and form tests now use row-action menus for edit and delete operations. Cart tests check row-action menu behavior, and CartView positions the total row from the table columns. The openstack-uicore-foundation dependency version changed to 5.0.75.
Changes: Sponsor UI updates
Layer / File(s)
Summary
Row-action menu tests package.json, src/pages/sponsors/show-pages-list-page/__tests__/show-pages-list-page.test.js, src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/__tests__/sponsor-forms-tab.test.js, src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/__tests__/sponsor-pages-tab.test.js
Tests select Edit and Delete from row-action menus instead of clicking icon buttons. The openstack-uicore-foundation dependency changes to 5.0.75.
Cart actions and total-row layout src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/cart-view.js, src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/__tests__/cart-view.test.js
Cart tests check row-action menu visibility and items. CartView derives total-row column positions from the amount column index and table column count.
The change updates the table library and adapts the cart total row and tests to the new row-actions menu. No concrete merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the two main parts of the change: the uicore dependency bump to 5.0.75 (package.json, one line) and the adjustments for the new row actions menu in the sponsor cart and tests. The cart…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the two main parts of the change: the uicore dependency bump to 5.0.75 (package.json, one line) and the adjustments for the new row actions menu in the sponsor cart and tests. The cart-view.js column-count change is a real part of the change but is not named. The title is specific and matches the changeset, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
package.json
Parsing error: Missing semicolon. (2:8)
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Essentials
Run ID: 494c1bab-fc8a-498b-a359-7a3110698439
Commits
Reviewing files that changed from the base of the PR and between 26ee4c3 and 0c43c89.
Files ignored due to path filters: 1
yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
No active review issues remain for the dependency upgrade and row-actions menu compatibility changes.
No open issues 🎉
What changed in this PR
Updates summit-admin to openstack-uicore-foundation 5.0.75 and adapts sponsor tables to its unified row-actions menu. This pairs the compatibility changes from #1147 with the required dependency bump, allowing #1141 to rebase onto them.
Changes:
Updates the dependency pin and lockfile to 5.0.75.
Aligns the cart total using MuiTable’s reported column count and removes the unused responsive option.
Updates four test suites to use the row-actions menu instead of separate Edit/Delete buttons.
The reason will be displayed to describe this comment to others. Learn more.
Approving. One non-blocking note.
One behaviour change from the bump that the description doesn't call out: archived rows lose Edit and Delete on the two MuiTableEditable tables that set disableProp: "is_archived".
On 5.0.73-beta.1 the editable table's Edit and Delete buttons had no disabled prop, so an archived item could still be opened or deleted. On 5.0.75 both sit behind RowActionsMenu, which is disabled when row[options.disableProp] is truthy. With Show Archived on, an admin now has to unarchive an item before editing or deleting it.
This matches how the plain MuiTable pages already behave, so it may be what we want. Can you confirm it's intended? Nothing in the suite would catch it either way: the manage-items tests mock the table, and the item-list tests have no row-action assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caseylocker
left a comment
ref: https://app.clickup.com/t/9014802374/86bcxj2kh
Summary
Bumps
openstack-uicore-foundationfrom5.0.73-beta.1to5.0.75(latest 5.0.x) and updates summit-admin for the row actions menu that 5.0.74 introduced (OpenStackweb/openstack-uicore-foundation#380), which replaces MuiTable's Edit and Delete icon columns with a single ⋮ menu.cart-viewcomputescolGap/trailingfrom the column count MuiTable now passes to a function child, so the total stays under Amount (editable cart: 9 columns, read-only: 7).options={{ responsive: false }}fromcart-view. uicore no longer reads it.action-edit/action-deleteor theEditIcon/DeleteIconbuttons.The
cart-viewand test changes are the commit from #1147 by @ako3131, cherry-picked unchanged. This PR adds the version bump that #1147 was waiting on. The two have to land together: on5.0.73-beta.1MuiTable renderschildrenas-is, so the function child renders no total row.Once this merges, #1141 can drop its own uicore bump and rebase onto it.
Tests
yarn jest(full run, local): 2233 of 2243 pass. The 10 failures are 5000 ms timeouts in five suites unrelated to this change (event-form,event-form-notify,page-template-popup,delete-extra-question-popup,process-request-popup), hit while the machine was under load. All 74 tests in those suites pass with--runInBandon both5.0.75and5.0.73-beta.1.show-pages-list-page,cart-view,sponsor-forms-tab,sponsor-pages-tab) pass on5.0.75.eslinton the changed files: 0 errors.Summary by CodeRabbit