Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
There was a problem hiding this comment.
🟡 Changes recommended
The declared uicore dependency does not invoke the new callback, causing the cart total row to disappear unless the dependency and lockfile are updated or the existing child rendering is retained.
1 open issue
What changed in this PR
Prepares summit-admin for uicore’s consolidated row-actions menu and keeps the sponsor cart total aligned with the Amount column.
Changes:
- Calculates total-row spacing from the Amount column position and MuiTable’s column count.
- Removes the obsolete responsive option.
- Updates sponsor tests to open the actions menu and select Edit/Delete by name.
| File | Description |
|---|---|
src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/__tests__/sponsor-pages-tab.test.js |
Updates page-edit interactions to use the menu. |
src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/__tests__/sponsor-forms-tab.test.js |
Updates delete interactions and action-visibility assertions. |
src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/cart-view.js |
Calculates total-row spans dynamically and removes the obsolete option. |
src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/__tests__/cart-view.test.js |
Checks menu availability and Edit/Delete entries. |
src/pages/sponsors/show-pages-list-page/__tests__/show-pages-list-page.test.js |
Updates edit and delete interactions to use the menu. |
Review effort: Balanced
| ) : ( | ||
| <TotalRow total={cart?.total} colGap={4} trailing={1} /> | ||
| {/* aligns the total under amount; MuiTable passes its column count */} | ||
| {(colCount) => ( |
… deleted responsive options
9433aba to
23978c3
Compare
|
@ako3131 heads up: #1153 supersedes this PR. It cherry-picks your commit (23978c3) unchanged, with your authorship, and adds the openstack-uicore-foundation bump to 5.0.75 that this PR was waiting on. The two have to land together: on 5.0.73-beta.1 MuiTable renders Once #1153 merges, this one can be closed. |

ref: https://app.clickup.com/t/9014802374/86bcxj2kh
Summary
Updates summit-admin for the uicore row actions menu (OpenStackweb/openstack-uicore-foundation#380), which replaces the Edit and Delete icon columns with a single ⋮ menu.
cart-viewno longer hard-codescolGap/trailing. It uses the column count thatMuiTablenow passes to a function child, so the total stays under Amount when columns or action columns change.options={{ responsive: false }}fromcart-view. uicore no longer reads it.action-edit/action-deleteor theEditIcon/DeleteIconbuttons.Depends on
uicore#380 merged and published. The
openstack-uicore-foundationversion bump is still to come.