Skip to content

fix: adjust for updated row actions - #1147

Draft
ako3131 wants to merge 1 commit into
masterfrom
fix/row-actions-update
Draft

ako3131 wants to merge 1 commit into
masterfrom
fix/row-actions-update

Conversation

@ako3131

@ako3131 ako3131 commented Nov 3, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bcxj2kh

Summary

Updates summit-admin for the uicore row actions menu (OpenStackweb/openstack-uicore-foundation#380), which replaces the Edit and Delete icon columns with a single ⋮ menu.

  • Cart total row: cart-view no longer hard-codes colGap/trailing. It uses the column count that MuiTable now passes to a function child, so the total stays under Amount when columns or action columns change.
  • Removed options={{ responsive: false }} from cart-view. uicore no longer reads it.
  • Tests: cart view, show pages list, sponsor forms tab and sponsor pages tab now open the ⋮ menu and pick Edit/Delete by name, instead of clicking action-edit/action-delete or the EditIcon/DeleteIcon buttons.

Depends on

uicore#380 merged and published. The openstack-uicore-foundation version bump is still to come.

@ako3131
ako3131 requested a balanced review from Copilot November 3, 2026 22:00
@ako3131 ako3131 self-assigned this Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The declared uicore dependency does not invoke the new callback, causing the cart total row to disappear unless the dependency and lockfile are updated or the existing child rendering is retained.

1 open issue
What changed in this PR

Prepares summit-admin for uicore’s consolidated row-actions menu and keeps the sponsor cart total aligned with the Amount column.

Changes:

  • Calculates total-row spacing from the Amount column position and MuiTable’s column count.
  • Removes the obsolete responsive option.
  • Updates sponsor tests to open the actions menu and select Edit/Delete by name.
File Description
src/​pages/​sponsors/​sponsor-page/​tabs/​sponsor-pages-tab/​__tests__/​sponsor-pages-tab.test.js Updates page-edit interactions to use the menu.
src/​pages/​sponsors/​sponsor-page/​tabs/​sponsor-forms-tab/​__tests__/​sponsor-forms-tab.test.js Updates delete interactions and action-visibility assertions.
src/​pages/​sponsors/​sponsor-page/​tabs/​sponsor-cart-tab/​components/​cart-view.js Calculates total-row spans dynamically and removes the obsolete option.
src/​pages/​sponsors/​sponsor-page/​tabs/​sponsor-cart-tab/​components/​__tests__/​cart-view.test.js Checks menu availability and Edit/Delete entries.
src/​pages/​sponsors/​show-pages-list-page/​__tests__/​show-pages-list-page.test.js Updates edit and delete interactions to use the menu.

Review effort: Balanced

) : (
<TotalRow total={cart?.total} colGap={4} trailing={1} />
{/* aligns the total under amount; MuiTable passes its column count */}
{(colCount) => (
@ako3131
ako3131 force-pushed the fix/row-actions-update branch from 9433aba to 23978c3 Compare November 12, 2026 17:21
caseylocker added a commit that referenced this pull request Nov 12, 2026
Picks up the UploadInputV4 fix that calls onRemove when a row is deleted
or an in-flight upload is cancelled (uicore #385).

5.0.74 and later also replace the MuiTable Edit and Delete icon columns
with a row actions menu, so four sponsor table test suites fail on this
version until #1147 merges.
@smarcet

smarcet commented Nov 13, 2026

Copy link
Copy Markdown

@ako3131 heads up: #1153 supersedes this PR.

It cherry-picks your commit (23978c3) unchanged, with your authorship, and adds the openstack-uicore-foundation bump to 5.0.75 that this PR was waiting on. The two have to land together: on 5.0.73-beta.1 MuiTable renders children as-is, so the function child renders no cart total row.

Once #1153 merges, this one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants