Refactor/row actions by ako3131 · Pull Request #380 · OpenStackweb/openstack-uicore-foundation

ako3131 · 2026-11-03T19:11:08Z

ref: https://app.clickup.com/t/9014802374/86bcxj2kh

Summary

Replaces the separate Edit and Delete icon columns in MuiTable, EditableTable and SortableTable with a single ⋮ row actions menu.

The menu shows Edit, then any custom actions, a divider, then Delete in red.
New getRowActions(row) prop on all three tables for extra menu items ({ label, onClick, disabled }).
Disabled rows (options.disableProp): Edit and Delete are greyed out. The ⋮ button stays enabled while any custom action is enabled. EditableTable now disables them too; before, its Edit and Delete stayed clickable on disabled rows.
canDelete(row) === false hides Delete in MuiTable.
MuiTable drops its responsive "collapse actions into a menu" behaviour, because the menu is now always used.
Adds the i18n key general.more_actions.
Not changed: BulkEditTable and SortableTableV2 since they are not in summit admin. I scoped it to summit admin so it is easier to manage.

Follow ups

-Move archiving into the row actions button
-Create linkable cells instead of full row clicks. For example, clicking the name of a summit brings you to the corresponding edit page.

Breaking changes (fixes are in fntechgit/summit-admin#1147)

Test selectors: data-testid="action-edit" / "action-delete" and the EditIcon / DeleteIcon buttons are gone. Tests should click row-actions-menu-trigger, then select the menuitem by name.
Column count: tables with both onEdit and onDelete have one fewer action column. Extra rows passed as children with fixed column spans (e.g. TotalRow trailing) need adjusting.
Removed option: options.responsive is now ignored.

Question

-Should table rows be editable/deletable when archived?

…rd a null row actions

coderabbitai · 2026-11-03T19:11:18Z

Important

Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 1371d328-03d4-4821-add3-41ca6b87ea13

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot

🟡 Changes recommended

The sortable table does not pass the row-disabled flag to RowActionsMenu, leaving Edit/Delete clickable for disabled rows.

1 open issue

Pass the row's disabled state to RowActionsMenu · New

What changed in this PR

Consolidates Edit and Delete into a shared row-actions menu across MuiTable, EditableTable, and SortableTable, with support for custom per-row actions.

Changes:

Replaces separate action columns with an always-visible menu column.
Adds custom actions, shared disabled-state handling, and a translated menu label.
Updates table tests to use menu interactions and cover custom actions.

File	Description
`src/i18n/en.json`	Adds the “More actions” label.
`src/components/mui/tables/sortable-table/index.js`	Integrates the shared menu and custom row actions.
`src/components/mui/tables/mui-table/index.js`	Replaces responsive action collapsing with a single menu column.
`src/components/mui/tables/editable-table/index.js`	Integrates the menu and disables built-in actions on disabled rows.
`src/components/mui/tables/components/row-actions-menu.js`	Adds built-in actions, custom items, and trigger accessibility attributes.
`src/components/mui/__tests__/mui-table.test.js`	Tests menu callbacks, deletion visibility, and disabled states.
`src/components/mui/__tests__/mui-table-sortable.test.js`	Updates action tests and adds custom-action coverage.
`src/components/mui/__tests__/mui-table-editable.test.js`	Updates menu tests, disabled-state checks, and cell expectations.

_{Review effort: Balanced}

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

santipalenque

@ako3131 please also consolidate with this PR so that both tables work and look coherent: #377

santipalenque · 2026-11-04T14:36:47Z

  onEdit,
  onArchive,
  onDelete,
+  getRowActions,


this would entail a change in every single instance of MuiTable, touching too many lines in show admin and sponsor services. What is the point of this ? Can we avoid passing it as prop and keep using columns with a flag to mark it as an action ? We need to try to be as little invasive as possible.

It was an optional way to add items into the row actions 3 dots button. No tables use it yet so I can just remove it. I'll hold off on making the flag until there's a real need to add column buttons into the row actions button.

santipalenque · 2026-11-04T14:39:30Z

-            {onDelete && <TableCell sx={{ ...ACTION_CELL_SX, ...getIndividualActionSx() }} />}
-            {onSelect && <TableCell sx={{ ...ACTION_CELL_SX, ...getIndividualActionSx() }} />}
-            {collapseActions && <TableCell sx={{ ...ACTION_CELL_SX, ...menuCellSx }} />}
+            {onArchive && <TableCell sx={ACTION_CELL_SX} />}


Leaving "Archive" out of the menu is on purpose ? just checking

I was going to put this in a follow up pr.

Also, I'm sorry I didn't clarify earlier, but I am closing #377 and splitting up the table action changes into smaller PRs (including this one).

santipalenque

LGTM, just a couple of nit picks if you want to make the code cleaner

santipalenque · 2026-11-06T12:48:32Z

+            aria-haspopup="true"
+            aria-expanded={anchorEl ? "true" : undefined}
+            disabled={
+              (!hasBuiltIns || disabled) && actions.every((action) => action.disabled)


lets move this to its own const

santipalenque · 2026-11-06T12:49:25Z

        open={Boolean(anchorEl)}
        onClose={() => setAnchorEl(null)}
      >
+        {onEdit && (


looks like if we merge actions with onEdit, the code gets simpler

ako3131 added 4 commits November 3, 2026 13:02

refactor: replace row edit/delete icons with a row actions menu

347ed3b

fix: revert row actions change on tabels not used in summit admin

ec6fcdd

fix: disable edit and delete on editable tables

e98dff0

fix: remove leftover hover, make extra actions button accessible, gua…

3f8f274

…rd a null row actions

ako3131 requested a balanced review from Copilot November 3, 2026 19:11

ako3131 self-assigned this Nov 3, 2026

Copilot started reviewing on behalf of ako3131 November 3, 2026 19:11

View session

Copilot AI reviewed Nov 3, 2026

View reviewed changes

Comment thread src/components/mui/tables/sortable-table/index.js Resolved

ako3131 and others added 2 commits November 3, 2026 13:22

Fix: JSX syntax for row actions in sortable table

a2af6eb

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix: allow tables to take in the number of rows

1e2edea

ako3131 mentioned this pull request Nov 3, 2026

fix: adjust for updated row actions fntechgit/summit-admin#1147

Draft

ako3131 requested a review from santipalenque November 3, 2026 22:03

santipalenque requested changes Nov 4, 2026

View reviewed changes

fix: remove row actions

5ebd416

ako3131 requested a review from santipalenque November 4, 2026 19:29

santipalenque approved these changes Nov 6, 2026

View reviewed changes

ako3131 merged commit a81d56c into main Nov 9, 2026
5 checks passed

caseylocker mentioned this pull request Nov 12, 2026

feat(uploads): select UploadInputV4 behind FILE_UPLOAD_USE_V4 fntechgit/summit-admin#1141

Open

smarcet mentioned this pull request Nov 13, 2026

chore(deps): update uicore to 5.0.75 and adjust for row actions fntechgit/summit-admin#1153

Open

Navigation Menu

Repository navigation

Refactor/row actions - #380

Refactor/row actions#380
ako3131 merged 7 commits into
mainfrom
refactor/row-actions

ako3131 commented Nov 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

santipalenque left a comment

Uh oh!

santipalenque Nov 4, 2026

Uh oh!

ako3131 Nov 4, 2026 •

edited

Loading

Uh oh!

santipalenque Nov 4, 2026

Uh oh!

ako3131 Nov 4, 2026

Uh oh!

ako3131 Nov 4, 2026 •

edited

Loading

Uh oh!

santipalenque left a comment

Uh oh!

santipalenque Nov 6, 2026

Uh oh!

santipalenque Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ako3131 commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Follow ups

Breaking changes (fixes are in fntechgit/summit-admin#1147)

Question

Uh oh!

coderabbitai Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

santipalenque left a comment

Choose a reason for hiding this comment

Uh oh!

santipalenque Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

ako3131 Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santipalenque Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

ako3131 Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

ako3131 Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santipalenque left a comment

Choose a reason for hiding this comment

Uh oh!

santipalenque Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

santipalenque Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ako3131 commented Nov 3, 2026 •

edited

Loading

coderabbitai Bot commented Nov 3, 2026 •

edited

Loading

ako3131 Nov 4, 2026 •

edited

Loading

ako3131 Nov 4, 2026 •

edited

Loading