Skip to content

Go: Add new import path for nhooyr.io/websocket - #22653

Open
owen-mc wants to merge 5 commits into
github:mainfrom
owen-mc:go/mad/update-nhooyr-io-websocket
Open

owen-mc wants to merge 5 commits into
github:mainfrom
owen-mc:go/mad/update-nhooyr-io-websocket

Conversation

@owen-mc

@owen-mc owen-mc commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Active development on this package moved in August 2024. This PR adds the new import path, along with the old one (which still works).

Copilot AI balanced review requested due to automatic review settings September 22, 2026 15:29
@owen-mc
owen-mc requested a review from a team as a code owner September 22, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The source models omit the required group: prefix and therefore match neither supported package path.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity · 2 Low severity

Open (3)
What changed in this PR

Adds support for the migrated github.com/coder/websocket import path while retaining the legacy path.

Changes:

  • Groups both package paths under shared models.
  • Updates WebSocket framework matching.
  • Adds a change note.
File Description
go/​ql/​lib/​semmle/​go/​frameworks/​WebSocket.qll Matches both WebSocket import paths.
go/​ql/​lib/​ext/​nhooyr.io.websocket.model.yml Removes the superseded standalone models.
go/​ql/​lib/​ext/​github.com.coder.websocket.model.yml Introduces grouped source models.
go/​ql/​lib/​change-notes/​2026-09-22-nhooyr-package-rename.md Documents the added import path.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go/ql/lib/ext/github.com.coder.websocket.model.yml Outdated
Comment thread go/ql/lib/semmle/go/frameworks/WebSocket.qll Outdated
Comment thread go/ql/lib/semmle/go/frameworks/WebSocket.qll
@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
+    Others,``github.com/coder/websocket``,2,,
-    Totals,,688,1134,1580
+    Totals,,690,1134,1580
  • Changes to framework-coverage-go.csv:
+ github.com/coder/websocket,,2,,,,,,,,,,,,,,,,,,,,,,2,,,

@owen-mc
owen-mc requested a review from a team September 22, 2026 15:35
owen-mc and others added 4 commits September 22, 2026 17:35
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@owen-mc
owen-mc force-pushed the go/mad/update-nhooyr-io-websocket branch from 50e1cd0 to aa9cf16 Compare September 22, 2026 16:36
@owen-mc
owen-mc force-pushed the go/mad/update-nhooyr-io-websocket branch from aa9cf16 to 2505d14 Compare September 22, 2026 18:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants