Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The source models omit the required group: prefix and therefore match neither supported package path.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds support for the migrated github.com/coder/websocket import path while retaining the legacy path.
Changes:
- Groups both package paths under shared models.
- Updates WebSocket framework matching.
- Adds a change note.
| File | Description |
|---|---|
go/ql/lib/semmle/go/frameworks/WebSocket.qll |
Matches both WebSocket import paths. |
go/ql/lib/ext/nhooyr.io.websocket.model.yml |
Removes the superseded standalone models. |
go/ql/lib/ext/github.com.coder.websocket.model.yml |
Introduces grouped source models. |
go/ql/lib/change-notes/2026-09-22-nhooyr-package-rename.md |
Documents the added import path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Click to show differences in coveragegoGenerated file changes for go
+ Others,``github.com/coder/websocket``,2,,
- Totals,,688,1134,1580
+ Totals,,690,1134,1580
+ github.com/coder/websocket,,2,,,,,,,,,,,,,,,,,,,,,,2,,, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
owen-mc
force-pushed
the
go/mad/update-nhooyr-io-websocket
branch
from
September 22, 2026 16:36
50e1cd0 to
aa9cf16
Compare
owen-mc
force-pushed
the
go/mad/update-nhooyr-io-websocket
branch
from
September 22, 2026 18:27
aa9cf16 to
2505d14
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Active development on this package moved in August 2024. This PR adds the new import path, along with the old one (which still works).