Repository navigation
perf(v3): defer lazy root proof during workspace admission - #216
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 834df63004
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| (if matches!(request.delivery, WorkspaceDelivery::Lazy) { | ||
| trace_async( | ||
| "root_metadata_bind", | ||
| Mst2Fuse::from_reader_lazy_deferred( |
There was a problem hiding this comment.
Update the remaining eager-failure fixtures
For a denied root with delivery: lazy, this branch now skips the request that produced the expected error and successfully mounts the workspace, as the new regression test demonstrates. However, opted_in_read_checkpoints_are_bounded_owner_specific_and_do_not_change_strict_status (tests/mst2_workspace_v3_http.rs:483-488) and destroying_failed_preparation_retires_unknown_cache_use_without_private_directories (tests/mst2_workspace_v3_http.rs:803-816) still submit lazy requests and require a 500 response plus failed/no-mount state, so both tests will deterministically fail on Linux; make those remaining eager-failure fixtures use full delivery or rewrite their assertions for successful lazy admission.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a416ade01
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| owner_guard.finish(result.clone()); | ||
| result | ||
| } else { | ||
| let notified = gate.notify.notified(); |
There was a problem hiding this comment.
Register the directory waiter before checking the result
When concurrent first accesses load the same directory on different executor threads, the owner can set result and call notify_waiters() after this waiter observes None but before its Notified future is first polled. Tokio does not retain a notify_waiters() permit for an unregistered future, so this waiter can sleep forever and indefinitely hang the FUSE operation. Pin and enable the notification future before checking result, or use a primitive that atomically publishes and observes completion.
Useful? React with 👍 / 👎.
1103d48 to
aaca9f7
Compare
Problem
Creating a lazy v3 workspace currently proves the entire root metadata page before the mount is exposed. On wide monorepos this makes admission latency scale with root size and duplicates the first namespace access.
Change
WorkspaceDelivery::Lazyuntil the first namespace operation.This is v3-only behavior and contains no legacy protocol fallback or benchmark artifacts.
Validation
cargo fmt -- --check(stable; passes)git diff --check(passes)