Repository navigation
perf(v3): defer lazy root proof during workspace admission #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a27dab6
perf(v3): defer lazy root metadata proof until access
Ivanbeethoven 5b135cb
test(v3): keep eager root failure cases on full delivery
Ivanbeethoven aaf3a33
perf(v3): coalesce concurrent lazy directory proofs
Ivanbeethoven 60daa70
fix(v3): keep lazy load mutex guards out of await
Ivanbeethoven ec308fb
fix(v3): keep mount probes metadata lazy
Ivanbeethoven 984b497
test(v3): expose lazy admission failure details
Ivanbeethoven 72858d1
test(v3): cover deferred admission without native mount
Ivanbeethoven aaca9f7
fix(v3): use watch channel in DirectoryLoadGate to prevent lost wakeups
genedna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a denied root with
delivery: lazy, this branch now skips the request that produced the expected error and successfully mounts the workspace, as the new regression test demonstrates. However,opted_in_read_checkpoints_are_bounded_owner_specific_and_do_not_change_strict_status(tests/mst2_workspace_v3_http.rs:483-488) anddestroying_failed_preparation_retires_unknown_cache_use_without_private_directories(tests/mst2_workspace_v3_http.rs:803-816) still submit lazy requests and require a 500 response plus failed/no-mount state, so both tests will deterministically fail on Linux; make those remaining eager-failure fixtures use full delivery or rewrite their assertions for successful lazy admission.Useful? React with 👍 / 👎.