Repository navigation
fix(model): use each non-dict placeholder item instead of the whole list - #2071
Open
AsherLucas wants to merge 1 commit into
Open
AsherLucas wants to merge 1 commit into
AsherLucas wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1971.
Problem
In ChatPromptClient.compile, when a placeholder value is a list and an item is not a dict, the code appended str(placeholder_value) — the whole list — for every such item. So compile(history=["a", "b"]) produced two identical messages containing "['a', 'b']", instead of one message per item.
Change
Verification


Confidence Score: 5/5
This PR appears safe to merge.Summary
Fixes
ChatPromptClient.compileso each non-dictionary placeholder item becomes its own string instead of repeating the whole list.Reviews (1) · Last reviewed commit: "fix(model): use each non-dict placeholde..." · Reviewed by Greptile