Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion langfuse/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def compile(
compiled_messages.append(
ChatMessageDict(
role="NOT_GIVEN",
content=str(placeholder_value),
content=str(msg),
)
)
no_role_content_in_placeholder = f"Placeholder '{placeholder_name}' should contain a list of chat messages with 'role' and 'content' fields. Appended as string."
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_prompt.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
4,
[
"You are a helpful assistant",
"['invalid message', {'role': 'user', 'content': 'valid message'}]",
"invalid message",
"valid message",
"Help me with coding",
],
Expand Down
31 changes: 31 additions & 0 deletions tests/unit/test_prompt_compilation.py
Original file line number Diff line number Diff line change
Expand Up @@ -932,3 +932,34 @@ def test_tool_calls_preservation_in_message_placeholder():
# Final user message with compiled variable
assert compiled_messages[4]["role"] == "user"
assert compiled_messages[4]["content"] == "Help me with weather inquiry"


def test_compile_non_dict_placeholder_items_use_each_item():
"""Non-dict placeholder items should each be appended as their own string.

Regression test for langfuse/langfuse-python#1971: previously every
non-dict item produced the same message containing the whole list.
"""
prompt_client = ChatPromptClient(
Prompt_Chat(
type="chat",
name="non_dict_placeholder_test",
version=1,
config={},
tags=[],
labels=[],
prompt=[
{"type": "chatmessage", "role": "system", "content": "hi {{x}}"},
{"type": "placeholder", "name": "history"},
],
)
)

compiled_messages = prompt_client.compile(x="1", history=["a", "b"])

assert len(compiled_messages) == 3
assert compiled_messages[0] == {"role": "system", "content": "hi 1"}
assert compiled_messages[1]["role"] == "NOT_GIVEN"
assert compiled_messages[1]["content"] == "a"
assert compiled_messages[2]["role"] == "NOT_GIVEN"
assert compiled_messages[2]["content"] == "b"
Loading