You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
moss-image : view qkv slices instead of slice+reshape - #2232
The qkv projections were split with ggml_ext_slice followed by ggml_reshape_4d, which materialised a copy of each slice. A ggml_view_4d over the fused qkv tensor reads the same elements in place.
Together with the ggml submodule bump (rope changes, cpy changes) this takes 50-step 1024x1024 sampling from 379.49 s to 356.12 s (-6.16%) with byte-identical output.
The qkv projections were split with ggml_ext_slice followed by
ggml_reshape_4d, which materialised a copy of each slice. A ggml_view_4d
over the fused qkv tensor reads the same elements in place.
Together with the ggml submodule bump this takes 50-step 1024x1024 sampling
from 379.49 s to 356.12 s (-6.16%) with byte-identical output.
No actionable comments were generated in the recent review.
Walkthrough
The ggml subproject reference changed. In TextBlock::forward, Q, K, and V are now strided 4D views into the combined QKV tensor instead of separate sliced and reshaped tensors.
The change replaces QKV slice-and-reshape copies with strided views and bumps ggml for a reported speedup. On AMD WMMA-capable builds the ggml update may shift outputs slightly, but the repository does not promise bit-identical output across ggml bumps. No merge-blocking risk remains.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description check
The description clearly explains the QKV view change, the performance impact, output validation, and checklist status. The optional Related Issue / Discussion and Additional Information headings are n…
Title check
The title clearly and concisely describes the main change: using QKV views instead of slice and reshape operations.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description clearly explains the QKV view change, the performance impact, output validation, and checklist status. The optional Related Issue / Discussion and Additional Information headings are not present, but the relevant verification details are included.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: fbd3da62-e9ac-4475-bd9e-9c0509dd96c7
Commits
Reviewing files that changed from the base of the PR and between be48649 and e349f08.
Files selected for processing: 2
ggml
src/model/diffusion/moss_image.hpp
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leejet
left a comment
The qkv projections were split with ggml_ext_slice followed by ggml_reshape_4d, which materialised a copy of each slice. A ggml_view_4d over the fused qkv tensor reads the same elements in place.
Together with the ggml submodule bump (rope changes,
cpychanges) this takes 50-step 1024x1024 sampling from 379.49 s to 356.12 s (-6.16%) with byte-identical output.Checklist
Summary by CodeRabbit