Skip to content

moss-image : view qkv slices instead of slice+reshape #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leejet merged 4 commits into from
Nov 3, 2026
Merged

moss-image : view qkv slices instead of slice+reshape #2232

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b15dd9b
moss-image : view qkv slices instead of slice+reshape
pwilkin Oct 27, 2026
e349f08
Merge branch 'master' into moss-image-rope-copy
pwilkin Oct 27, 2026
067fd8d
Merge branch 'master' into moss-image-rope-copy
leejet Nov 3, 2026
a9f100f
Merge branch 'master' into moss-image-rope-copy
leejet Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/model/diffusion/moss_image.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ namespace MOSSImage {
auto y = norm("norm1", x);
auto qkv = linear("qkv", y);
auto split = [&](int i) {
return ggml_reshape_4d(c, ggml_ext_slice(c, qkv, 0, i * config.dim, (i + 1) * config.dim), config.head_dim, config.dim / config.head_dim, x->ne[1], x->ne[2]);
// q/k feed rms_norm and v a permuted copy, which read these strided views in place.
return ggml_view_4d(c, qkv, config.head_dim, config.dim / config.head_dim, x->ne[1], x->ne[2], config.head_dim * qkv->nb[0], qkv->nb[1], qkv->nb[2], i * config.dim * qkv->nb[0]);
};
auto q = norm("q_norm", split(0));
auto k = norm("k_norm", split(1));
Expand Down
Loading