[Eugene (OEvgeny)]

An activity re-sent with the same ID but a different (or no) HowTo isPartOf is rendered twice; development builds throw "graph has N activities, Redux has N+1 activities".

Changelog Entry

Fixed

• Fixed activities updated into, out of, or between part groupings rendered twice, in PR #5967, by @OEvgeny

Description

When an update moved an activity out of, into, or between HowTo part groupings, upsert() added it by its new grouping but never removed it from its previous place. It now removes the previous revision (and an emptied grouping) before inserting the update.

Design

• Reuses deleteActivityByLocalId() for non-livestream activities whose HowTo grouping ID changed, instead of a second removal path inside upsert(); updates within the same grouping are untouched.
• Livestream revisions are excluded because their grouping belongs to the session, so deleting one revision would un-finalize or split it.

Specific Changes

• sort/upsert.ts: remove the previous revision when its HowTo grouping changed
• upsert.howTo.spec.ts: leave a grouping, move to another (emptied one dropped), join a grouping, same grouping unchanged
• upsert.howToWithLivestream.spec.ts: a re-sent final or older revision without isPartOf keeps the session finalized and renders once

• I have added tests and executed them locally
• I have added .changelog/<PR#>-<slug>.md
• I have updated documentation

Review Checklist

This section is for contributors to review your work.

• Accessibility reviewed (tab order, content readability, alt text, color contrast)
• Browser and platform compatibilities reviewed
• CSS styles reviewed (minimal rules, no z-index)
• Documents reviewed (docs, samples, live demo)
• Internationalization reviewed (strings, unit formatting)
• package.json and package-lock.json reviewed
• Security reviewed (no data URIs, check for nonce leak)
• Tests reviewed (coverage, legitimacy)

[Eugene (OEvgeny)]

William Wong (@compulim), a question for a follow-up (this PR deliberately leaves livestream activities alone):

A livestream session in a HowTo grouping can get a later revision with another isPartOf (another grouping, or none). Today upsert() keeps the session in its old place and adds it to the new one, so the revision renders twice. Which grouping should the session follow?

• A. Its latest (highest-sequence) revision's grouping: same as plain activities in this PR, and the UI already bins each rendered revision by its own isPartOf (createDefaultGroupActivitiesMiddleware.ts).
• B. Its first revision's grouping: later revisions inherit it; the UI binning must then change too, because the rendered revision's isPartOf disagrees.

We recommend A. OK to go with A?

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.