[小卡塔克 (Goldloli)]

Fixes #3902

What

TemplateSegmentConverter._build_identifier now includes the ordered prompt_template.parameters list in the identifier params, replacing the bare number_parameters count. Two converters sharing a template text but binding parameters in different orders now produce distinct hashes and can be registered under automatic default names simultaneously.

The parameter count was redundant once the ordered list is part of the identity, so it is replaced rather than kept alongside.

Why

The ordered parameters list controls which prompt segment fills which template parameter in convert_async (dict(zip(parameters, segments))), so ["left", "right"] and ["right", "left"] render differently. The identity previously captured only the template text hash, the parameter count, and the seed, so both orderings hashed identically and the second automatic registration failed with ValueError: Instance 'TemplateSegmentConverter::…' already exists.

Verification

The repro from the issue, on this branch:

hash equal: False
both registered OK

(before the fix: hash equal: True, then ValueError on the second registration)

pytest tests/unit/converter/test_template_segment_converter.py: 12 passed — including the new regression test test_template_segment_converter_identity_includes_parameter_order, which fails on the unpatched source (verified by stashing the fix) and passes with it.

Note: the identifier hash for every existing TemplateSegmentConverter changes once, because number_parameters is replaced by the full ordered list in the hashed params. Existing persisted identifiers will not match after upgrade.

[Copilot]

🟢 Approval recommended

No active review issues remain for the change that distinguishes converter identities by parameter binding order.

No open issues 🎉

What changed in this PR

Fixes #3902 by making TemplateSegmentConverter identity reflect parameter binding order, allowing differently ordered configurations to coexist under automatic registry names.

Changes:

• Replaces the parameter count in identifier data with the ordered parameter names.
• Adds a regression test verifying that reversed parameter orders produce distinct hashes.
• Changes existing converter hashes once on upgrade, as noted in the PR description.

File	Description
tests/​unit/​converter/​test_template_segment_converter.py	Adds regression coverage for parameter-order identity.
pyrit/​converter/​template_segment_converter.py	Includes ordered parameter names in the identifier.

_{Review effort: Balanced}

[小卡塔克 (Goldloli)]

@microsoft-github-policy-service agree

[小卡塔克 (Goldloli)]

The Build latest failure looks transient: the docs link checker got a 504 (Gateway Time-out) for https://github.com/leondz/garak. The link resolves fine now (301 → NVIDIA/garak), and this PR only touches pyrit/converter/template_segment_converter.py + its unit test, so a re-run of that job should go green.