Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyrit/converter/template_segment_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _build_identifier(self) -> ComponentIdentifier:
return self._create_identifier(
params={
"template_hash": template_hash,
"number_parameters": self._number_parameters,
"parameters": self.prompt_template.parameters,
"seed": self._seed,
}
)
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/converter/test_template_segment_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,17 @@ async def test_template_segment_converter_invalid_input_type():
converter = TemplateSegmentConverter()
with pytest.raises(ValueError, match="Input type not supported"):
await converter.convert_async(prompt="test", input_type="image_path")


def test_template_segment_converter_identity_includes_parameter_order():
"""Test that reversing the ordered parameters produces a different identifier hash.

The ordered parameter list controls which prompt segment fills which template
parameter, so two converters that differ only in that order are behaviorally
distinct and must not collide in the registry.
"""
template = "LEFT[{{left}}] RIGHT[{{right}}]"
first = TemplateSegmentConverter(prompt_template=SeedPrompt(value=template, parameters=["left", "right"]), seed=7)
second = TemplateSegmentConverter(prompt_template=SeedPrompt(value=template, parameters=["right", "left"]), seed=7)

assert first.get_identifier().hash != second.get_identifier().hash
Loading