Skip to content

ci: pass environment secrets to called workflows by name - #2238

Merged
martin-helmich merged 1 commit into
masterfrom
ci/pass-environment-secrets
Nov 19, 2026
Merged

martin-helmich merged 1 commit into
masterfrom
ci/pass-environment-secrets

Conversation

@martin-helmich

Copy link
Copy Markdown
Member

The scheduled Dependabot run failed in every `Apply` job (run 44469573889): `The 'client-id' (or deprecated 'app-id') input must be set to a non-empty string`.

A job in a called workflow can use secrets of its `environment`, but only if the caller passes them, by name or with `secrets: inherit`. Otherwise they resolve to an empty string without an error (docs). Dispatching `review-dependabot-pr.yml` directly worked, which hid the problem.

This passes the secrets by name and declares them in `on.workflow_call.secrets`:

  • `review-dependabot-prs.yml` → `review-dependabot-pr.yml`: `DEPENDENCY_APP_*` (both jobs), `MITTWALD_AI_API_KEY` (review only).
  • `release.yml` → `release-announcement.yml`: `MITTWALD_AI_API_KEY`, which would have been empty on the next release as well.

Passing a secret by name doesn't widen access: the value still comes from the environment of the job that uses it, so the review job (`ai-agents`) can't read the app credentials and the apply job (`dependency-updates`) can't read the AI key.

🤖 Generated with Claude Code

A called workflow only sees an environment secret if the caller passes it,
by name or with `secrets: inherit`; otherwise it is silently empty. The
scheduled Dependabot run therefore failed to create the app token, and the
release announcement had no AI API key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@martin-helmich
martin-helmich merged commit dd423bc into master Nov 19, 2026
11 checks passed
@martin-helmich
martin-helmich deleted the ci/pass-environment-secrets branch November 19, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant