Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/release-announcement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@ name: Announce release on Discord
# release note to a Discord webhook. Called from release.yml.
on:
workflow_call:
# MITTWALD_AI_API_KEY is a secret of the "ai-agents" environment, which
# cannot be passed in by the caller.
secrets:
DISCORD_WEBHOOK_URL:
description: Discord webhook URL the release note is posted to.
required: true
# A secret of the "ai-agents" environment (announce job). The caller
# still has to pass it by name, otherwise it is empty here.
MITTWALD_AI_API_KEY:
required: true

permissions:
contents: read
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@ jobs:
uses: ./.github/workflows/release-announcement.yml
secrets:
DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_WEBHOOK_URL }}
# Environment secret of "ai-agents"; it has to be passed by name even
# though this job can't read it.
MITTWALD_AI_API_KEY: ${{ secrets.MITTWALD_AI_API_KEY }}

cleanup-artifacts:
runs-on: ubuntu-latest
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/review-dependabot-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,17 @@ on:
Skip the agent review and merge as soon as the required checks pass.
type: boolean
default: false
# No secrets are passed in: MITTWALD_AI_API_KEY is a secret of the
# "ai-agents" environment (review job), the dependency app's credentials
# are secrets of the "dependency-updates" environment (apply job).
# These are environment secrets: MITTWALD_AI_API_KEY of "ai-agents"
# (review job), the dependency app's credentials of "dependency-updates"
# (apply job). The caller still has to pass them by name, otherwise they
# are empty here. Each job only gets the values of its own environment.
secrets:
MITTWALD_AI_API_KEY:
required: false
DEPENDENCY_APP_CLIENT_ID:
required: true
DEPENDENCY_APP_PRIVATE_KEY:
required: true
workflow_dispatch:
inputs:
pr:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/review-dependabot-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ jobs:
with:
pr: ${{ matrix.pr }}
fast-track: true
# Environment secrets of "dependency-updates"; they have to be passed by
# name even though the caller can't read them.
secrets:
DEPENDENCY_APP_CLIENT_ID: ${{ secrets.DEPENDENCY_APP_CLIENT_ID }}
DEPENDENCY_APP_PRIVATE_KEY: ${{ secrets.DEPENDENCY_APP_PRIVATE_KEY }}

review:
name: Review PR #${{ matrix.pr }}
Expand All @@ -113,3 +118,9 @@ jobs:
uses: ./.github/workflows/review-dependabot-pr.yml
with:
pr: ${{ matrix.pr }}
# Environment secrets of "ai-agents" and "dependency-updates"; they have
# to be passed by name even though the caller can't read them.
secrets:
MITTWALD_AI_API_KEY: ${{ secrets.MITTWALD_AI_API_KEY }}
DEPENDENCY_APP_CLIENT_ID: ${{ secrets.DEPENDENCY_APP_CLIENT_ID }}
DEPENDENCY_APP_PRIVATE_KEY: ${{ secrets.DEPENDENCY_APP_PRIVATE_KEY }}