Repository navigation
fix(client): wait for slow HTTP discovery in Auto mode - #1435
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-test
Contributor
|
@jamadeo is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
charliermarsh
force-pushed
the
charlie/http-discovery-fallback
branch
3 times, most recently
from
November 6, 2026 18:14
2cfa51f to
cec7d60
Compare
charliermarsh
changed the title
charliermarsh
force-pushed
the
charlie/http-discovery-fallback
branch
from
November 6, 2026 18:35
cec7d60 to
0fff88e
Compare
charliermarsh
force-pushed
the
charlie/http-discovery-fallback
branch
from
November 6, 2026 18:49
0fff88e to
74d1079
Compare
charliermarsh
marked this pull request as ready for review
November 6, 2026 19:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At present, a Streamable HTTP server that takes 12 seconds to answer
server/discovercan fail to connect inAutomode. After 10 seconds, the client queues a legacyinitializerequest with ID 1. The HTTP worker is still reading the discovery POST, so when the server replies with ID 0, the client rejects the correct reply withexpected 1, got 0(see: openai/codex#57631).In this PR, Auto still gives discovery 10 seconds, including time spent sending the probe and negotiating a version. Then, when the HTTP transport accepts the probe, it marks that request before the send future is polled. If the 10 seconds expire, Auto keeps waiting for that HTTP handshake within the caller’s startup deadline. A JSON or SSE reply can finish discovery, and an explicit legacy rejection still triggers
initializeimmediately.