Skip to content

deps: v8: cherry-pick e1686cd20e83 - #67708

Open
fatihguzeldev wants to merge 1 commit into
nodejs:mainfrom
fatihguzeldev:v8-detach-immutable
Open

fatihguzeldev wants to merge 1 commit into
nodejs:mainfrom
fatihguzeldev:v8-detach-immutable

Conversation

@fatihguzeldev

Copy link
Copy Markdown
Contributor

follow-up to #67388, as suggested by @jasnell.

cherry-picks v8/v8@e1686cd20e83 so IsDetachable() returns false
for immutable ArrayBuffers. the existing node-api check then
returns napi_detachable_arraybuffer_expected.

the upstream regression assertion is in the corresponding v8 cctest.

report immutable ArrayBuffers as non-detachable so the existing
node-api check returns napi_detachable_arraybuffer_expected.

Refs: v8/v8@e1686cd
Refs: nodejs#67388
Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@github-actions

Copy link
Copy Markdown
Contributor

Hi! This pull request changes deps/v8 on the main branch without updating the V8 version, so you are likely submitting a backport of individual V8 patches.

In general we recommend waiting for a V8 patch to be included in the next V8 major version update instead of fast-tracking it, since individual backports add audit cost and can delay the major update.

A patch may be backported to main when at least one of these criteria applies:

  • It fixes a build issue on a platform or toolchain supported on main.
  • It fixes a security issue.
  • It unblocks a pending V8 update, for example by adjusting how the Node.js code uses a V8 API so that it works with the future update.

If the patch has demonstrated real-world urgency and impact that justifies landing it before the next V8 major version update, it's recommended to backport it to the release staging branches like v<MAJOR>.x-staging (see Criteria for backporting to decide what release line to target) instead of main.

Please explain in the pull request description which of these criteria applies. Otherwise, consider closing this pull request and waiting for the next V8 update instead of fast-tracking a backport. See Backporting patches to main for details.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2026
@Renegade334

Copy link
Copy Markdown
Member

Immutable ArrayBuffers still sit disabled by default behind a V8 flag, I don't see that there's any need to backport this. It can just land naturally with the V8 16.0 update when it comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants