Repository navigation
deps: v8: cherry-pick e1686cd20e83 - #67708
fatihguzeldev wants to merge 1 commit into
Conversation
report immutable ArrayBuffers as non-detachable so the existing node-api check returns napi_detachable_arraybuffer_expected. Refs: v8/v8@e1686cd Refs: nodejs#67388 Signed-off-by: Fatih Güzel <fatihguzeldev@gmail.com>
|
Review requested:
|
|
Hi! This pull request changes In general we recommend waiting for a V8 patch to be included in the next V8 major version update instead of fast-tracking it, since individual backports add audit cost and can delay the major update. A patch may be backported to
If the patch has demonstrated real-world urgency and impact that justifies landing it before the next V8 major version update, it's recommended to backport it to the release staging branches like Please explain in the pull request description which of these criteria applies. Otherwise, consider closing this pull request and waiting for the next V8 update instead of fast-tracking a backport. See Backporting patches to |
|
Immutable ArrayBuffers still sit disabled by default behind a V8 flag, I don't see that there's any need to backport this. It can just land naturally with the V8 16.0 update when it comes. |
follow-up to #67388, as suggested by @jasnell.
cherry-picks v8/v8@e1686cd20e83 so
IsDetachable()returns falsefor immutable
ArrayBuffers. the existing node-api check thenreturns
napi_detachable_arraybuffer_expected.the upstream regression assertion is in the corresponding v8 cctest.