Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
1 change: 1 addition & 0 deletions deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ Elisha Hollander <just4now666666@gmail.com>
Eric Rannaud <eric.rannaud@gmail.com>
Erich Ocean <erich.ocean@me.com>
Evan Lucas <evan.lucas@help.com>
Fatih Güzel <fatihguzeldev@gmail.com>
Fedor Indutny <fedor@indutny.com>
Felix Geisendörfer <haimuiba@gmail.com>
Feng Yu <f3n67u@gmail.com>
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-array-buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class V8_EXPORT ArrayBufferBase : public Object {

/**
* Returns true if this ArrayBuffer may be detached. Always false for
* SharedArrayBuffer.
* immutable ArrayBuffers and SharedArrayBuffers.
*/
bool IsDetachable() const;

Expand Down
1 change: 1 addition & 0 deletions deps/v8/src/api/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9238,6 +9238,7 @@ bool v8::ArrayBufferBase::IsShared() const {
}

bool v8::ArrayBufferBase::IsDetachable() const {
if (IsImmutable()) return false;
return Utils::OpenDirectHandle(this)->is_detachable();
}

Expand Down
1 change: 1 addition & 0 deletions deps/v8/test/cctest/test-api-array-buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,7 @@ TEST(ArrayBuffer_ImmutableBackingStore) {
v8::ArrayBuffer::New(isolate, shared_backing_store);

CHECK(ab->IsImmutable());
CHECK(!ab->IsDetachable());
}

TEST(ArrayBuffer_CopyArrayBufferBytes) {
Expand Down
Loading