Repository navigation
feat(DEP0192): migrate internal TLS imports to node:tls - #577
Open
vishalrajofficial wants to merge 2 commits into
Open
vishalrajofficial wants to merge 2 commits into
vishalrajofficial wants to merge 2 commits into
Conversation
Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
seem good but huge point:
- the type part should be skipped or improved. to improve I invite you to create/add new utility to the utility part
- the logic same complicated maybe try to use more utility that has been already create
- there are serval
kind() ===which should be replaced byis()
Simplify workflow.ts by leveraging @nodejs/codemod-utils directly for import statements and require calls. Replace kind() === checks with .is(), remove verbose type annotations, handle CRLF and LF newlines dynamically, and update test fixtures. Signed-off-by: Vishal Raj <9031842908.vk@gmail.com>
Author
|
Thanks for the thorough review! Updated:
All 12 recipe tests, type checks, and linting pass cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a codemod for DEP0192 to migrate imports of internal Node.js TLS modules (
_tls_common,_tls_wrap) to the publicnode:tlsmodule.Features
_tls_common(SecureContext,createSecureContext) and_tls_wrap(TLSSocket,Server,createServer,connect) tonode:tls.node:prefixed specifiers (e.g._tls_commonandnode:_tls_wrap).node:tls.translatePeerCertificate), escaped namespace objects, and unknown properties, emitting warnings for manual review.Fixes #554