Repository navigation
Conversation
Rename the "Heat Pumps" Library/My Model category to "Plant Loop Heat Pumps" and list the plant heat pump types the app was missing: HeatPump:PlantLoop:EIR Heating/Cooling, HeatPump:AirToWater:FuelFired Heating/Cooling, and HeatPump:AirToWater (wrapper plus its Heating and Cooling operation modes in My Model). Dropping a HeatPump:AirToWater wrapper on a plant loop asks whether to place its heating or cooling mode (preselected from the loop's sizing type) and places that mode, since the wrapper itself cannot go on a node. Placement logic lives in utilities/HeatPumpAirToWaterPlacement with unit tests. Add default instances of the new types to hvac_library.osm (EIR air source, fuel-fired, and an air-to-water wrapper with one speed per mode); verified to forward translate cleanly. Add icons for the new types and redraw the water-to-water icons so heating and cooling differ. The air-to-water wrapper and its modes share one icon. Icon tests check distinctness and no Catchall fallback. Translations: new strings hand-inserted into all .ts files. Note: the SVG sources for the new icons are held outside the repo for now, pending a decision on whether they should be published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
My Model now lists only the HeatPump:AirToWater wrapper, not its heating and cooling operation modes. Selecting a mode on a loop opens an Edit tab that shows the owning HeatPump:AirToWater first, then the selected mode with its speed data, on one scrolling page (new HeatPumpAirToWaterModeInspectorView). A mode owned by a wrapper is not removable on its own in the SDK, so the loop diagram showed no delete button for it. It now gets one: clicking it takes the mode off that loop, and when neither mode is left on a loop the wrapper is removed along with both modes, their speed data, curves and lists, since the GUI has no other way to delete it. Translations: drop the two mode strings that are no longer listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
macumber
reviewed
Oct 19, 2026
macumber
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, I left a few comments. I think it would be good to have the svgs so I would add them if you can.
- Move Central Heat Pump System into the Plant Loop Heat Pumps library
category and drop the separate category (and its translations)
- Replace HeatPumpAirToWaterMode with HeatPumpAirToWaterType
{ Wrapper, Heating, Cooling } and look it up by IddObjectType, so
non air-to-water objects skip the wrapper lookup
- Inspector for an air-to-water mode shows the wrapper, the selected
mode, then the other mode
- Library HeatPump:AirToWater uses the speed 1 heating and cooling
curves from EnergyPlus PlantLoopHeatPump_EIR_AirSource_and_AWHP.idf
and the EnergyPlus cooling rating defaults (30 C air, 8 C water);
the SDK defaults gave the cooling mode heating values
(NatLabRockies/OpenStudio#5675)
- Library air-source HeatPump:PlantLoop:EIR units use the capacity and
EIR curves from PlantLoopHeatPump_EIR_AirSource_Hospital_wSixPipeHeatRecovery.idf
instead of flat curves
- Add f(x) to the water-to-water equation fit icons
- Add the SVG sources for the Plant Loop Heat Pump icons
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks for the review! Added the SVG sources in |
macumber
reviewed
Nov 15, 2026
| namespace { | ||
|
|
||
| // An InspectorGadget without its own scroll area, so several can be stacked in one scrolling page | ||
| class StackedInspectorGadget : public InspectorGadget |
Collaborator
There was a problem hiding this comment.
Nitpick, I don't think this class adds enough value to exist, I would just call the InspectorGadget constructor with these arguments and comment below.
Collaborator
|
Looks good to me, I approved, I will let you decide if you want to address nitpick #896 (comment) or not. |
macumber
approved these changes
Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plant Loop Heat Pumps: missing types, library defaults, and icons
Problem
Several plant-side heat pump types supported by the SDK could not be dragged from a library or from My Model, because the HVAC Library and My Model lists didn't include them. For example, an
OS:HeatPump:PlantLoop:EIR:Heatingin a custom library OSM did not appear anywhere. The existing "Heat Pumps" category name was also vague, since the app has many non-plant heat pumps.Changes
Library / My Model lists (
MainRightColumnController.cpp)HeatPump:PlantLoop:EIR:Heating/:CoolingHeatPump:AirToWater:FuelFired:Heating/:CoolingHeatPump:AirToWater. Both lists show only the wrapper; its operation modes are not listed separately.Placing
HeatPump:AirToWater(HVACSystemsController.cpp, newutilities/HeatPumpAirToWaterPlacement)HeatPumpAirToWaterType { Wrapper, Heating, Cooling }is looked up by IddObjectType. Deleting from a loop, the loop drawing and the inspector check it first, so other objects skip the wrapper lookup.utilities, separate from the UI, so it can be unit tested.Editing
HeatPump:AirToWater(InspectorView.cpp)HeatPump:AirToWater, then the selected mode, then the other mode, each with its speed data. Selecting a mode that has no wrapper keeps the standard view.Default library instances (
hvac_library.osm)HeatPump:AirToWaterwrapper with Heating and Cooling modes (one speed each), plus their curves.HeatPump:AirToWater: the speed 1 heating and cooling curves fromPlantLoopHeatPump_EIR_AirSource_and_AWHP.idf. The cooling mode is rated at the EnergyPlus defaults of 30 °C inlet air and 8 °C leaving water.HeatPump:PlantLoop:EIR: the heating and cooling capacity and EIR curves fromPlantLoopHeatPump_EIR_AirSource_Hospital_wSixPipeHeatRecovery.idf, instead of the SDK's flat curves.HeatPump:AirToWateris emitted.Icons (
IconLibrary.cpp,openstudio.qrc,images/,images/mini_icons/,images/svg/)src/openstudio_lib/images/svg/, with a README on exporting them to PNG. The app doesn't load them.Translations
OpenStudioApp_*.tsfiles, and the removed "Central Heat Pump Systems" string was deleted from them. I edited them by hand rather than running a full lupdate pass, because develop's.tsfiles are out of sync with the sources and lupdate would add about 26k lines of unrelated location changes. A check run of lupdate found no missing strings, and lrelease reports 0 unfinished.Before:


After:
Tests
HeatPumpAirToWaterPlacement_GTest(new):Wrapperas the mode to place, is rejected;IconLibrary_GTest(2 new tests):openstudioapp_utilities_tests: 14/14 passed.openstudio_lib_tests: everything passed except the known baselineAnalyticsHelperSecrets, which needs CI secrets.Notes for reviewers
HeatPumpAirToWaterCoolingthe heating rating conditions and its speed data the heating curves. The library works around this; reported upstream as HeatPumpAirToWaterCooling and HeatPumpAirToWaterCoolingSpeedData constructors use heating-mode ratings and curves NatLabRockies/OpenStudio#5675.🤖 Generated with Claude Code