Repository navigation
Plant Loop Heat Pumps: missing types, library defaults, and icons #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ski90Moo
wants to merge
3
commits into
openstudiocoalition:develop
Choose a base branch
from
Ski90Moo:feature/library-plantloop-eir-heatpumps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,557
−170
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+9.28 KB
src/openstudio_lib/images/heatpump_airtowater_fuelfired_cooling@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.93 KB
src/openstudio_lib/images/heatpump_airtowater_fuelfired_heating@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+298 Bytes
(110%)
src/openstudio_lib/images/heatpump_watertowater_equationfit_cooling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.47 KB
(63%)
src/openstudio_lib/images/heatpump_watertowater_equationfit_cooling@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+112 Bytes
(100%)
src/openstudio_lib/images/heatpump_watertowater_equationfit_heating.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.37 KB
(57%)
src/openstudio_lib/images/heatpump_watertowater_equationfit_heating@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+854 Bytes
src/openstudio_lib/images/mini_icons/heatpump_airtowater_fuelfired_cooling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.62 KB
src/openstudio_lib/images/mini_icons/heatpump_airtowater_fuelfired_cooling@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+848 Bytes
src/openstudio_lib/images/mini_icons/heatpump_airtowater_fuelfired_heating.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.62 KB
src/openstudio_lib/images/mini_icons/heatpump_airtowater_fuelfired_heating@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+704 Bytes
src/openstudio_lib/images/mini_icons/heatpump_plantloop_eir_cooling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.35 KB
src/openstudio_lib/images/mini_icons/heatpump_plantloop_eir_cooling@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+702 Bytes
src/openstudio_lib/images/mini_icons/heatpump_plantloop_eir_heating.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.35 KB
src/openstudio_lib/images/mini_icons/heatpump_plantloop_eir_heating@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+214 Bytes
(130%)
src/openstudio_lib/images/mini_icons/heatpump_watertowater_equationfit_cooling.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.12 KB
(64%)
...enstudio_lib/images/mini_icons/heatpump_watertowater_equationfit_cooling@2x.png
Oops, something went wrong.
Binary file modified
BIN
+198 Bytes
(120%)
src/openstudio_lib/images/mini_icons/heatpump_watertowater_equationfit_heating.png
Oops, something went wrong.
Binary file modified
BIN
-1.12 KB
(64%)
...enstudio_lib/images/mini_icons/heatpump_watertowater_equationfit_heating@2x.png
|
macumber marked this conversation as resolved.
Resolved
|
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Icon sources | ||
|
|
||
| SVG sources for the Plant Loop Heat Pump icons. The app loads the PNGs in `images/` and `images/mini_icons/`, | ||
| not these files. | ||
|
|
||
| | SVG | PNGs | | ||
| |---|---| | ||
| | `<name>.svg` | `images/<name>.png` (100 px) and `images/<name>@2x.png` (200 px) | | ||
| | `<name>_mini.svg` | `images/mini_icons/<name>.png` (24 px) and `images/mini_icons/<name>@2x.png` (48 px) | | ||
|
|
||
| The air-to-water wrapper and its heating and cooling modes share `heatpump_airtowater`. | ||
|
|
||
| ## Exporting | ||
|
|
||
| `export.html` draws one SVG at a given size on a transparent page. Screenshot it with headless Chrome, once per size: | ||
|
|
||
| ```sh | ||
| chrome --headless=new --hide-scrollbars --allow-file-access-from-files --default-background-color=00000000 \ | ||
| --window-size=200,200 --screenshot=heatpump_airtowater@2x.png \ | ||
| "file:///<path to this folder>/export.html?f=heatpump_airtowater.svg&s=200" | ||
| ``` | ||
|
|
||
| The f(x) labels on the water-to-water (equation fit) icons use the system's Georgia font. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| <!doctype html><html><head><style>html,body{margin:0;padding:0;background:transparent;overflow:hidden}img{display:block}</style></head> | ||
| <body><img id="i"><script>const q=new URLSearchParams(location.search);const i=document.getElementById('i');i.src=q.get('f');i.width=i.height=+q.get('s');</script></body></html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, I don't think this class adds enough value to exist, I would just call the InspectorGadget constructor with these arguments and comment below.