Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #711 (the display precision part).
str(robot)printed prismatic joint limits as raw floats, so a limit of0.30479999999999996(for example 12 inches converted to metres) showed up with all the float noise in both the standard and modified DH tables. Every other column already goes throughformat_attr.This runs the prismatic limits through
format_attras well, so that limit now displays as0.3048. Only the display changes. Stored limits and dynamics are untouched.Tests: added
tests/test_DHRobot_display.py, which builds a prismatic link with that limit for bothPrismaticDHandPrismaticMDHand checks the output. It fails onmainand passes with this change. The full test suite (excludingtest_blocks.py) passes: 778 passed, 70 skipped.This does not add the separate
.table()API suggested in the issue; that would need some design discussion first.