Repository navigation
docs: one true statement about what PHARN deletes (C4.2, CORE-175) - #416
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
🛡️ pharn-ci ·
|
| Verdict | Diff coverage | Test integrity | Agent setup |
|---|---|---|---|
| no coverable lines | 29 files |
🧪 Diff coverage
No coverable lines changed.
🔍 Test integrity
⚠️ TI07tests/root-migration.test.ts:534— The test "the ROOT MIGRATION note › previews in the future tense" changed only an expected value of its toContain assertion, in a change that also edits source files.- Hint: Check each new expected value against what the code should do, not what it now returns; if the behaviour change is meant, say so in the PR so a reviewer can confirm it.
Tests changed: +0 −0 ~2
| Test file | Added | Removed | Modified | Renamed |
|---|---|---|---|---|
tests/orphans.test.ts |
0 | 0 | 1 | 0 |
tests/root-migration.test.ts |
0 | 0 | 1 | 0 |
💬 Messages (1)
- ℹ️
NO_COVERABLE_CHANGESNo added lines are tracked by the coverage report; nothing to measure.- Hint: Nothing to do if the change has no code; otherwise check that the coverage report includes the changed files.
🤖 Agent setup (29 files)
Agent setup: 29 files · claude-code
Agent setup files (29)
| Path | Kind |
|---|---|
.claude/commands/pharn-dev-build.md |
claude-command |
.claude/commands/pharn-dev-eval.md |
claude-command |
.claude/commands/pharn-dev-grill.md |
claude-command |
.claude/commands/pharn-dev-memory-promote.md |
claude-command |
.claude/commands/pharn-dev-plan.md |
claude-command |
.claude/commands/pharn-dev-regress.md |
claude-command |
.claude/commands/pharn-dev-review.md |
claude-command |
.claude/commands/pharn-dev-ship.md |
claude-command |
.claude/commands/pharn-dev-verify.md |
claude-command |
.claude/hooks/enforce-writes-scope.cjs |
claude-hook |
.claude/hooks/enforce-writes-scope.test.cjs |
claude-hook |
.claude/hooks/git-worktree-fixture.cjs |
claude-hook |
.claude/hooks/protect-trusted-paths.cjs |
claude-hook |
.claude/hooks/protect-trusted-paths.test.cjs |
claude-hook |
.claude/hooks/session-root.cjs |
claude-hook |
.claude/hooks/session-root.test.cjs |
claude-hook |
.claude/hooks/set-writes-scope.cjs |
claude-hook |
.claude/hooks/set-writes-scope.test.cjs |
claude-hook |
.claude/settings.json |
claude-settings |
.claude/skills/phargus-diagnose |
claude-skill |
.claude/skills/phargus-memory |
claude-skill |
.claude/skills/phargus-rules |
claude-skill |
.claude/skills/phargus-setup |
claude-skill |
.claude/skills/phargus-verify |
claude-skill |
.claude/skills/pharn-ci-cover |
claude-skill |
.claude/skills/pharn-ci-explain |
claude-skill |
.claude/skills/pharn-ci-install |
claude-skill |
.claude/skills/pharn-cli |
claude-skill |
CLAUDE.md |
claude-md |
pharn-ci 0.10.0 · report schema v2 · coverage format lcov
PrzemekGalarowicz
force-pushed
the
przemek/core-175-what-pharn-deletes
branch
from
November 17, 2026 12:49
b57fab5 to
561cf47
Compare
Add docs/reference/deletes.md, the one list of every delete a pharn command makes (dropped capability directories in update/init, remove, uninstall, record pruning, and pharn's own download, lock, empty pharn/ and temp files), the check behind each, and what is never deleted. Link it from docs/README.md and the command pages, and replace the sentences that contradicted the code: "Nothing deletes an orphan", "no pharn command can clear one", the removed root-migration delete in README.md, "a record key never causes a write or a delete", the roadmap's "nothing is deleted", and uninstall "never touches .claude/settings.json". The ORPHANED note now says "`pharn update` never deletes them" instead of "pharn never deletes them": uninstall deletes unchanged orphans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PrzemekGalarowicz
force-pushed
the
przemek/core-175-what-pharn-deletes
branch
from
November 17, 2026 12:52
561cf47 to
6c182ee
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: CORE-175 (epic CORE-153).
Adds
docs/reference/deletes.md, What PHARN deletes: every delete apharncommand makes, traced from the current code (rmSync/unlinkSync/rmdirSync/rename-away insrc/), the check behind each, and what is never deleted. The command pages link to it, and every sentence that contradicted the code is replaced.Ticket checklist
Delete paths (built from current
main, not the ticket's 0.18.2 list):update/ re-runinit: a dropped capability's directory, backed up first (capability-removal.ts,capability-dir.ts).THREAT-MODEL.md/LIMITS.md: moot, refactor: remove the flat layout and the root migration (CORE-155) [v0.21.0] #412 removed the root migration. The page lists them as orphans thatupdatenever deletes; README.md's stale "deletes the two docs" sentence is fixed.remove: one capability directory, unproven files backed up, records pruned.uninstall: recorded files at their recorded hash (incl..claude/settings.jsona freshinitcreated, per C2.4), empty dirs, the records, the config (backed up), an emptypharn/.memory-bank//pharn.spec-template.md: moot, removed (C1.1 / refactor: remove the flat layout and the root migration (CORE-155) [v0.21.0] #412). Listed under "never deleted".pharn/.lock, a stale lock's corpse (only by the breaker that made it; a stranded one never), an emptypharn/the lock created, a failed write's temp file. The "stale legacy root.pharn.lock" path is moot: removed in v0.20.0.flatleftovers (exceptuninstallof unchanged ones),.claude/settings.json(exceptuninstallof the oneinitcreated),.claude/settings.local.json,pharn/.backup/, user data incl. root.pharn-backup/and.pharn/,.gitignore/.prettierignorelines, anything behind a symlink.Contradicting sentences:
README.md"Nothing deletes an orphan" →updatenever deletes one;uninstallremoves the unchanged ones; link.README.mdroot-footprint paragraph (still described the removed migration deleting the docs) → true now; link.README.md"The only thing it deletes…" → kept as a true statement, plus link.uninstallrow: "Never touches.claude/settings.json" → "a.claude/settings.jsonit did not create".docs/commands/status.md"nopharncommand can clear one —updatenever deletes" → link.docs/commands/init.md"(initnever deletes)": now reads "(initnever deletes them)" about the flat copies, which is true; the dropped-capabilities section links the page.docs/commands/update.md"the only thingupdatedeletes" (x2) → true restatement + link; the ORPHANED note sample matches the new string.docs/reference/pharn-records.md"a record key never causes a write or a delete" → "never causes a write, and causes a delete only inuninstall".docs/roadmap.mdorphans row "nothing is deleted" → "updatekeeps them".docs/architecture.mdorphans "It is never deleted" → "updatenever deletes it"; deletes bullet links the page.docs/README.mdlinks the new page;remove.mdanduninstall.mdlink it.src/lib/orphans.tsCLI string "pharn never deletes them" → "pharn updatenever deletes them";tests/orphans.test.tsandtests/root-migration.test.tsassertions rewritten (noitremoved). CHANGELOG[Unreleased]→### Fixedline.LIMITS.md:72(src/commands/update.ts:452citation and "updatenever deletes"): LIMITS.md is human-owned and hook-protected, so it is fixed by a patch script the maintainer runs; it lands as a follow-up commit on this branch. The same patch fixes §1d's "reports nothing" (orphans are now named in theORPHANEDnote).Acceptance grep (
never delete,nothing deletes,only thing … deletes) overREADME.md docs/: every hit is now a true, scoped statement; the one inLIMITS.mdgoes with the patch.Test changes (pharn-ci TI07)
The behaviour change is intended.
tests/root-migration.test.ts("previews in the future tense") andtests/orphans.test.tschange only the expected text of theORPHANEDnote, frompharn never deletesto`pharn update` never(the orphans test also asserts the old false sentence is gone). The old text was false:pharn uninstalldeletes an orphan that still equals its record (src/lib/uninstall-plan.ts).🤖 Generated with Claude Code